Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1655423002: Merge to XFA: Kill CFX_ByteArray in master. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Kill CFX_ByteArray in master. One trivial edit in fx_basic.h Includes both fixes for build breakage. Review URL: https://codereview.chromium.org/1653253002 . (cherry picked from commit 9b0a59d659d8083802385649ba74370d65c41e36) TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ed5d7aa789ec5ef7b440d7e56b71804b41a928e3

Patch Set 1 #

Patch Set 2 : IWYU for vector. #

Patch Set 3 : Still wonked. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -85 lines) Patch
M core/include/fpdfdoc/fpdf_doc.h View 1 2 7 chunks +13 lines, -30 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 2 chunks +1 line, -5 lines 0 comments Download
M core/src/fpdfdoc/doc_formcontrol.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 2 7 chunks +5 lines, -17 lines 0 comments Download
M core/src/fpdfdoc/doc_utils.h View 2 chunks +3 lines, -1 line 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 1 2 chunks +5 lines, -10 lines 0 comments Download
M fpdfsdk/include/fsdk_baseform.h View 1 chunk +1 line, -2 lines 0 comments Download
M fpdfsdk/src/fsdk_baseform.cpp View 1 chunk +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
Tom Sepez
Committed patchset #3 (id:40001) manually as ed5d7aa789ec5ef7b440d7e56b71804b41a928e3 (presubmit successful).
4 years, 10 months ago (2016-02-03 00:02:07 UTC) #4
Lei Zhang
4 years, 10 months ago (2016-02-03 00:14:39 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698