Kill CFX_ByteArray in master.

Kill CFX_ByteArray in master.

(Many more uses in XFA).

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/9b0a59d659d8083802385649ba74370d65c41e36

[Tom Sepez, 2016-02-01 23:49:48]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-01 23:49:49]

pls review.

[Lei Zhang, 2016-02-02 02:48:48]

lgtm

https://codereview.chromium.org/1653253002/diff/1/core/src/fpdfdoc/doc_utils.h
File core/src/fpdfdoc/doc_utils.h (right):

https://codereview.chromium.org/1653253002/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.h:57: void SaveCheckedFieldStatus(CPDF_FormField*
pField,
Do you want to do:

std::vector<uint8_t> SaveCheckedFieldStatus(CPDF_FormField* pField)

instead?

[Tom Sepez, 2016-02-02 17:20:53]

Quick re-review.  I ended up going to vector<bool> and inserted a few "consts"
along the way.

https://codereview.chromium.org/1653253002/diff/1/core/src/fpdfdoc/doc_utils.h
File core/src/fpdfdoc/doc_utils.h (right):

https://codereview.chromium.org/1653253002/diff/1/core/src/fpdfdoc/doc_utils....
core/src/fpdfdoc/doc_utils.h:57: void SaveCheckedFieldStatus(CPDF_FormField*
pField,
On 2016/02/02 02:48:48, Lei Zhang wrote:
> Do you want to do:
> 
> std::vector<uint8_t> SaveCheckedFieldStatus(CPDF_FormField* pField)
> 
> instead?
m'kay

[Tom Sepez, 2016-02-02 17:36:10]

Quick re-re-review.  It's gone.

https://codereview.chromium.org/1653253002/diff/20001/fpdfsdk/src/fsdk_basefo...
File fpdfsdk/src/fsdk_baseform.cpp (right):

https://codereview.chromium.org/1653253002/diff/20001/fpdfsdk/src/fsdk_basefo...
fpdfsdk/src/fsdk_baseform.cpp:2014: const std::vector<bool>& statusArray) {
Heh, unused, and the callers just pass it but dont otherwise use it.

[Lei Zhang, 2016-02-02 22:45:14]

lgtm

[Tom Sepez, 2016-02-02 23:26:01]

Description was changed from

==========
Kill CFX_ByteArray in master.

(Many more uses in XFA).
==========

to

==========
Kill CFX_ByteArray in master.

(Many more uses in XFA).

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/9b0a59d659d8083802385649ba74370d65c4...
==========

[Tom Sepez, 2016-02-02 23:26:02]

Committed patchset #3 (id:40001) manually as
9b0a59d659d8083802385649ba74370d65c41e36 (presubmit successful).