Fix some API documentation bugs in new pause on start exit APIs

Fix some API documentation bugs in new pause on start exit APIs

BUG=
R=turnidge@google.com

Committed: https://github.com/dart-lang/sdk/commit/bb2e633498a24f8f725526e3777323f3d4787fb9

[Cutch, 2016-02-04 00:19:27]

Description was changed from

==========
Fix some API documentation bugs in new pause on start exit APIs

BUG=
==========

to

==========
Fix some API documentation bugs in new pause on start exit APIs

BUG=
==========

[Cutch, 2016-02-04 00:19:27]

johnmccutchan@google.com changed reviewers:
+ turnidge@google.com

[turnidge, 2016-02-04 17:13:38]

lgtm w/ suggestions

https://codereview.chromium.org/1655393004/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/1655393004/diff/1/runtime/include/dart_api.h#...
runtime/include/dart_api.h:1088: * As well, Dart_SetShouldPauseOnStart and
Dart_SetShouldPauseOnExit can be used
optional: "As well" -> "Additionally"

https://codereview.chromium.org/1655393004/diff/1/runtime/include/dart_api.h#...
runtime/include/dart_api.h:1089: * to control this pausing on a per-isolate
basis.
opt: "pausing" -> "behavior"

https://codereview.chromium.org/1655393004/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1655393004/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1415: CURRENT_FUNC);
I could see allowing this to be set late.

[Cutch, 2016-02-04 17:26:58]

https://codereview.chromium.org/1655393004/diff/1/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/1655393004/diff/1/runtime/include/dart_api.h#...
runtime/include/dart_api.h:1088: * As well, Dart_SetShouldPauseOnStart and
Dart_SetShouldPauseOnExit can be used
On 2016/02/04 17:13:38, turnidge wrote:
> optional: "As well" -> "Additionally"

Done.

https://codereview.chromium.org/1655393004/diff/1/runtime/include/dart_api.h#...
runtime/include/dart_api.h:1089: * to control this pausing on a per-isolate
basis.
On 2016/02/04 17:13:38, turnidge wrote:
> opt: "pausing" -> "behavior"

Done.

https://codereview.chromium.org/1655393004/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1655393004/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:1415: CURRENT_FUNC);
On 2016/02/04 17:13:38, turnidge wrote:
> I could see allowing this to be set late.

Done and comment updated.

[Cutch, 2016-02-04 17:27:10]

Description was changed from

==========
Fix some API documentation bugs in new pause on start exit APIs

BUG=
==========

to

==========
Fix some API documentation bugs in new pause on start exit APIs

BUG=
R=turnidge@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bb2e633498a24f8f725526e3777323f3d4787fb9
==========

[Cutch, 2016-02-04 17:27:12]

Committed patchset #2 (id:20001) manually as
bb2e633498a24f8f725526e3777323f3d4787fb9 (presubmit successful).