runtime/vm/dart_api_impl.cc - Issue 1655393004: Fix some API documentation bugs in new pause on start exit APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1655393004: Fix some API documentation bugs in new pause on start exit APIs (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/dart_api_impl.cc

diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc

index c6b78b2648233269cf25bccfe6c96195a9550a54..ac2b4613d296d8ed8a45b87bacbda6537a879d94 100644

--- a/runtime/vm/dart_api_impl.cc

+++ b/runtime/vm/dart_api_impl.cc

@@ -1376,6 +1376,10 @@ DART_EXPORT bool Dart_ShouldPauseOnStart() {

DART_EXPORT void Dart_SetShouldPauseOnStart(bool should_pause) {

Isolate* isolate = Isolate::Current();

CHECK_ISOLATE(isolate);

+ if (isolate->is_runnable()) {

+ FATAL1("%s expects the current isolate to not be runnable yet.",

+ CURRENT_FUNC);

+ }

return isolate->message_handler()->set_should_pause_on_start(should_pause);

}

« no previous file with comments | « runtime/include/dart_api.h ('k') | no next file » | no next file with comments »