Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Issue 1655323002: Switch use-zoom-for-dsf flag to use tri-value flags (Closed)

Created:
4 years, 10 months ago by oshima
Modified:
4 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch use-zoom-for-dsf flag to use tri-value flags I'll enable this by default on chromeos devices in a separate CL. BUG=485650 Committed: https://crrev.com/82d23704d20d13450c128f9e6917e816dafb9e57 Cr-Commit-Position: refs/heads/master@{#373403}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +9 lines, -1 line 0 comments Download
M content/common/content_switches_internal.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655323002/40001
4 years, 10 months ago (2016-02-02 21:43:25 UTC) #6
oshima
avi-> content/common/content_switches_internal.cc owner
4 years, 10 months ago (2016-02-02 22:59:56 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-02 23:00:13 UTC) #11
Albert Bodenhamer
lgtm
4 years, 10 months ago (2016-02-02 23:20:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655323002/40001
4 years, 10 months ago (2016-02-02 23:24:30 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/141848)
4 years, 10 months ago (2016-02-02 23:45:15 UTC) #16
Avi (use Gerrit)
lgtm
4 years, 10 months ago (2016-02-03 02:49:02 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655323002/40001
4 years, 10 months ago (2016-02-03 23:47:39 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 10 months ago (2016-02-04 01:00:30 UTC) #21
commit-bot: I haz the power
4 years, 10 months ago (2016-02-04 01:01:24 UTC) #23
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82d23704d20d13450c128f9e6917e816dafb9e57
Cr-Commit-Position: refs/heads/master@{#373403}

Powered by Google App Engine
This is Rietveld 408576698