Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1655323002: Switch use-zoom-for-dsf flag to use tri-value flags (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | content/common/content_switches_internal.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 505 matching lines...) Expand 10 before | Expand all | Expand 10 after
516 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""}, 516 {IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", ""},
517 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_BOOKMARKS, 517 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_BOOKMARKS,
518 switches::kEnableOfflinePagesAsBookmarks, ""}, 518 switches::kEnableOfflinePagesAsBookmarks, ""},
519 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_SAVED_PAGES, 519 {IDS_FLAGS_ENABLE_OFFLINE_PAGES_AS_SAVED_PAGES,
520 switches::kEnableOfflinePagesAsSavedPages, ""}, 520 switches::kEnableOfflinePagesAsSavedPages, ""},
521 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages, 521 {IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED, switches::kDisableOfflinePages,
522 ""}, 522 ""},
523 }; 523 };
524 #endif // defined(OS_ANDROID) 524 #endif // defined(OS_ANDROID)
525 525
526 const FeatureEntry::Choice kEnableUseZoomForDSFChoices[] = {
527 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_DEFAULT, "", ""},
528 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_ENABLED,
529 switches::kEnableUseZoomForDSF, "true" },
530 { IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_CHOICE_DISABLED,
531 switches::kEnableUseZoomForDSF, "false" },
532 };
533
526 // RECORDING USER METRICS FOR FLAGS: 534 // RECORDING USER METRICS FOR FLAGS:
527 // ----------------------------------------------------------------------------- 535 // -----------------------------------------------------------------------------
528 // The first line of the entry is the internal name. If you'd like to gather 536 // The first line of the entry is the internal name. If you'd like to gather
529 // statistics about the usage of your flag, you should append a marker comment 537 // statistics about the usage of your flag, you should append a marker comment
530 // to the end of the feature name, like so: 538 // to the end of the feature name, like so:
531 // "my-special-feature", // FLAGS:RECORD_UMA 539 // "my-special-feature", // FLAGS:RECORD_UMA
532 // 540 //
533 // After doing that, run 541 // After doing that, run
534 // tools/metrics/actions/extract_actions.py 542 // tools/metrics/actions/extract_actions.py
535 // to add the metric to actions.xml (which will enable UMA to record your 543 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 1171 matching lines...) Expand 10 before | Expand all | Expand 10 after
1707 MULTI_VALUE_TYPE(kMarkNonSecureAsChoices)}, 1715 MULTI_VALUE_TYPE(kMarkNonSecureAsChoices)},
1708 {"enable-site-per-process", 1716 {"enable-site-per-process",
1709 IDS_FLAGS_SITE_PER_PROCESS_NAME, 1717 IDS_FLAGS_SITE_PER_PROCESS_NAME,
1710 IDS_FLAGS_SITE_PER_PROCESS_DESCRIPTION, 1718 IDS_FLAGS_SITE_PER_PROCESS_DESCRIPTION,
1711 kOsAll, 1719 kOsAll,
1712 SINGLE_VALUE_TYPE(switches::kSitePerProcess)}, 1720 SINGLE_VALUE_TYPE(switches::kSitePerProcess)},
1713 {"enable-use-zoom-for-dsf", 1721 {"enable-use-zoom-for-dsf",
1714 IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_NAME, 1722 IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_NAME,
1715 IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_DESCRIPTION, 1723 IDS_FLAGS_ENABLE_USE_ZOOM_FOR_DSF_DESCRIPTION,
1716 kOsDesktop, 1724 kOsDesktop,
1717 SINGLE_VALUE_TYPE(switches::kEnableUseZoomForDSF)}, 1725 MULTI_VALUE_TYPE(kEnableUseZoomForDSFChoices)},
1718 #if defined(OS_MACOSX) 1726 #if defined(OS_MACOSX)
1719 {"enable-harfbuzz-rendertext", 1727 {"enable-harfbuzz-rendertext",
1720 IDS_FLAGS_HARFBUZZ_RENDERTEXT_NAME, 1728 IDS_FLAGS_HARFBUZZ_RENDERTEXT_NAME,
1721 IDS_FLAGS_HARFBUZZ_RENDERTEXT_DESCRIPTION, 1729 IDS_FLAGS_HARFBUZZ_RENDERTEXT_DESCRIPTION,
1722 kOsMac, 1730 kOsMac,
1723 SINGLE_VALUE_TYPE(switches::kEnableHarfBuzzRenderText)}, 1731 SINGLE_VALUE_TYPE(switches::kEnableHarfBuzzRenderText)},
1724 #endif // defined(OS_MACOSX) 1732 #endif // defined(OS_MACOSX)
1725 #if defined(OS_CHROMEOS) 1733 #if defined(OS_CHROMEOS)
1726 {"disable-timezone-tracking", 1734 {"disable-timezone-tracking",
1727 IDS_FLAGS_RESOLVE_TIMEZONE_BY_GEOLOCATION_NAME, 1735 IDS_FLAGS_RESOLVE_TIMEZONE_BY_GEOLOCATION_NAME,
(...skipping 617 matching lines...) Expand 10 before | Expand all | Expand 10 after
2345 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2353 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2346 2354
2347 const FeatureEntry* GetFeatureEntries(size_t* count) { 2355 const FeatureEntry* GetFeatureEntries(size_t* count) {
2348 *count = arraysize(kFeatureEntries); 2356 *count = arraysize(kFeatureEntries);
2349 return kFeatureEntries; 2357 return kFeatureEntries;
2350 } 2358 }
2351 2359
2352 } // namespace testing 2360 } // namespace testing
2353 2361
2354 } // namespace about_flags 2362 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | content/common/content_switches_internal.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698