Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1655313003: Eagerly declare variables in ParseVariableDeclarations where possible (Closed)

Created:
4 years, 10 months ago by adamk
Modified:
4 years, 10 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Eagerly declare variables in ParseVariableDeclarations where possible This avoids spending lots of time in Scope::RemoveUnresolved for very long variable declaration lists. BUG=v8:4699 LOG=n Committed: https://crrev.com/f4f19408486abc12f2bcc93b30160db560cb65db Cr-Commit-Position: refs/heads/master@{#34047}

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -29 lines) Patch
M src/parsing/parser.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 7 chunks +40 lines, -23 lines 0 comments Download
M test/message/try-catch-lexical-conflict.out View 1 chunk +1 line, -1 line 0 comments Download
M test/message/try-catch-variable-conflict.out View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
adamk
4 years, 10 months ago (2016-02-12 22:46:47 UTC) #3
rossberg
lgtm
4 years, 10 months ago (2016-02-16 16:08:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1655313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1655313003/20001
4 years, 10 months ago (2016-02-16 18:32:16 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-16 19:09:07 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 19:09:53 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f4f19408486abc12f2bcc93b30160db560cb65db
Cr-Commit-Position: refs/heads/master@{#34047}

Powered by Google App Engine
This is Rietveld 408576698