Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Side by Side Diff: src/parsing/parser.h

Issue 1655313003: Eagerly declare variables in ParseVariableDeclarations where possible (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_PARSING_PARSER_H_ 5 #ifndef V8_PARSING_PARSER_H_
6 #define V8_PARSING_PARSER_H_ 6 #define V8_PARSING_PARSER_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/ast/scopes.h" 10 #include "src/ast/scopes.h"
(...skipping 860 matching lines...) Expand 10 before | Expand all | Expand 10 after
871 Expression* pattern_; 871 Expression* pattern_;
872 int initializer_position_; 872 int initializer_position_;
873 Block* block_; 873 Block* block_;
874 const DeclarationDescriptor* descriptor_; 874 const DeclarationDescriptor* descriptor_;
875 ZoneList<const AstRawString*>* names_; 875 ZoneList<const AstRawString*>* names_;
876 Expression* current_value_; 876 Expression* current_value_;
877 int recursion_level_; 877 int recursion_level_;
878 bool* ok_; 878 bool* ok_;
879 }; 879 };
880 880
881 881 Block* ParseVariableDeclarations(VariableDeclarationContext var_context,
882 void ParseVariableDeclarations(VariableDeclarationContext var_context, 882 DeclarationParsingResult* parsing_result,
883 DeclarationParsingResult* parsing_result, 883 ZoneList<const AstRawString*>* names,
884 bool* ok); 884 bool* ok);
885 Statement* ParseExpressionOrLabelledStatement( 885 Statement* ParseExpressionOrLabelledStatement(
886 ZoneList<const AstRawString*>* labels, bool* ok); 886 ZoneList<const AstRawString*>* labels, bool* ok);
887 IfStatement* ParseIfStatement(ZoneList<const AstRawString*>* labels, 887 IfStatement* ParseIfStatement(ZoneList<const AstRawString*>* labels,
888 bool* ok); 888 bool* ok);
889 Statement* ParseContinueStatement(bool* ok); 889 Statement* ParseContinueStatement(bool* ok);
890 Statement* ParseBreakStatement(ZoneList<const AstRawString*>* labels, 890 Statement* ParseBreakStatement(ZoneList<const AstRawString*>* labels,
891 bool* ok); 891 bool* ok);
892 Statement* ParseReturnStatement(bool* ok); 892 Statement* ParseReturnStatement(bool* ok);
893 Statement* ParseWithStatement(ZoneList<const AstRawString*>* labels, 893 Statement* ParseWithStatement(ZoneList<const AstRawString*>* labels,
894 bool* ok); 894 bool* ok);
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
1220 1220
1221 DoExpression* ParserTraits::ParseDoExpression(bool* ok) { 1221 DoExpression* ParserTraits::ParseDoExpression(bool* ok) {
1222 return parser_->ParseDoExpression(ok); 1222 return parser_->ParseDoExpression(ok);
1223 } 1223 }
1224 1224
1225 1225
1226 } // namespace internal 1226 } // namespace internal
1227 } // namespace v8 1227 } // namespace v8
1228 1228
1229 #endif // V8_PARSING_PARSER_H_ 1229 #endif // V8_PARSING_PARSER_H_
OLDNEW
« no previous file with comments | « no previous file | src/parsing/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698