src/preparser.cc - Issue 16549003: Fix crasher when checking for "of", but next token has no literal buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.cc

Issue 16549003: Fix crasher when checking for "of", but next token has no literal buffer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add test suite (thanks Michael) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/preparser.cc

diff --git a/src/preparser.cc b/src/preparser.cc

index 243a3ed34c52e20ca31b48d4bcffadd25bc8c8dd..828177aee0a696ddf51c75b2ca7867aacc163522 100644

--- a/src/preparser.cc

+++ b/src/preparser.cc

@@ -662,6 +662,7 @@ PreParser::Statement PreParser::ParseWhileStatement(bool* ok) {

bool PreParser::CheckInOrOf() {

if (peek() == i::Token::IN ||

(allow_for_of() &&

+ peek() == i::Token::IDENTIFIER &&

scanner_->is_next_contextual_keyword(v8::internal::CStrVector("of")))) {

Next();

return true;

« no previous file with comments | « no previous file | src/scanner.h » ('j') | no next file with comments »