src/scanner.h - Issue 16549003: Fix crasher when checking for "of", but next token has no literal buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/scanner.h

Issue 16549003: Fix crasher when checking for "of", but next token has no literal buffer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Add test suite (thanks Michael) Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/scanner.h

diff --git a/src/scanner.h b/src/scanner.h

index 368ec1beae557568aee0c52f65aa50f483a3b9d8..eb6764e80f3c4be38bbdbf73aedfcbe4dcb8af9e 100644

--- a/src/scanner.h

+++ b/src/scanner.h

@@ -331,7 +331,7 @@ class Scanner {

return current_.literal_chars->is_ascii();

}

bool is_literal_contextual_keyword(Vector<const char> keyword) {

- ASSERT_NOT_NULL(next_.literal_chars);

+ ASSERT_NOT_NULL(current_.literal_chars);

return current_.literal_chars->is_contextual_keyword(keyword);

}

int literal_length() const {

« no previous file with comments | « src/preparser.cc ('k') | test/mjsunit/regress/regress-crbug-248025.js » ('j') | no next file with comments »