Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 16549003: Fix crasher when checking for "of", but next token has no literal buffer (Closed)

Created:
7 years, 6 months ago by wingo
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix crasher when checking for "of", but next token has no literal buffer Also fix a typo in an assertion in scanner.h. R=mstarzinger@chromium.org BUG=248025 TEST=mjsunit/regress/regress-crbug-248025.js Committed: http://code.google.com/p/v8/source/detail?r=15059

Patch Set 1 #

Patch Set 2 : Add test suite (thanks Michael) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -17 lines) Patch
M src/preparser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/scanner.h View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-248025.js View 1 2 chunks +11 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wingo
An initial patch. Still figuring out how to test it.
7 years, 6 months ago (2013-06-10 11:39:09 UTC) #1
wingo
On 2013/06/10 11:39:09, wingo wrote: > An initial patch. Still figuring out how to test ...
7 years, 6 months ago (2013-06-10 15:30:08 UTC) #2
wingo
Updated patch adds test suite. Thanks to Michael for help reproducing the bug.
7 years, 6 months ago (2013-06-11 10:52:44 UTC) #3
Michael Starzinger
LGTM. Sorry for pestering you with the repro, but I think it is important to ...
7 years, 6 months ago (2013-06-11 11:01:38 UTC) #4
wingo
7 years, 6 months ago (2013-06-11 11:30:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r15059 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698