Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1654833002: [interpreter] Fix re-throw to not have frame-state. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Fix re-throw to not have frame-state. The runtime call to Runtime::kReThrow does not need a frame-state node attached, the frame-state input count is zero. This restructures the graph builder to not instantiate a FrameStateBeforeAndAfter for it. R=jarin@chromium.org TEST=cctest/test-run-bytecode-graph-builder BUG=v8:4674 LOG=n Committed: https://crrev.com/8420d57524870453824fd5d07981edf3f52628c0 Cr-Commit-Position: refs/heads/master@{#33641}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M src/compiler/bytecode-graph-builder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +9 lines, -9 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 10 months ago (2016-02-01 13:39:11 UTC) #1
Jarin
lgtm. Thanks!
4 years, 10 months ago (2016-02-01 13:46:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654833002/1
4 years, 10 months ago (2016-02-01 13:47:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 14:01:26 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 14:02:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8420d57524870453824fd5d07981edf3f52628c0
Cr-Commit-Position: refs/heads/master@{#33641}

Powered by Google App Engine
This is Rietveld 408576698