Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: test/cctest/compiler/test-run-bytecode-graph-builder.cc

Issue 1654833002: [interpreter] Fix re-throw to not have frame-state. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-bytecode-graph-builder.cc
diff --git a/test/cctest/compiler/test-run-bytecode-graph-builder.cc b/test/cctest/compiler/test-run-bytecode-graph-builder.cc
index d1ce501c52d3b23a472b66137332b5750a9fc168..b809e0cb43ae65452f9855f54f807be844a17fd3 100644
--- a/test/cctest/compiler/test-run-bytecode-graph-builder.cc
+++ b/test/cctest/compiler/test-run-bytecode-graph-builder.cc
@@ -1462,11 +1462,10 @@ TEST(BytecodeGraphBuilderTryFinally1) {
" try { a = 2; continue; } finally { a = 3; }"
"} return a + i;",
{handle(Smi::FromInt(23), isolate)}},
- // TODO(mstarzinger): Investigate failure!
- // {"var a = 1; try { a = 2;"
- // " try { a = 3; throw 23; } finally { a = 4; }"
- // "} catch(e) { a = a + e; } return a;",
- // {handle(Smi::FromInt(27), isolate)}},
+ {"var a = 1; try { a = 2;"
+ " try { a = 3; throw 23; } finally { a = 4; }"
+ "} catch(e) { a = a + e; } return a;",
+ {handle(Smi::FromInt(27), isolate)}},
};
size_t num_snippets = sizeof(snippets) / sizeof(snippets[0]);
« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698