Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1654803003: Improve readability of error messages for VADD in ARM assembler. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
Reviewers:
Jim Stichnoth
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve readability of error messages for VADD in ARM assembler. Fixes readability of error messages, based on comment in CL: https://codereview.chromium.org/1652173002 BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=c048712807db0daef403735bfb4fa0cb4bd0aff2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M src/IceAssemblerARM32.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M src/IceInstARM32.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
4 years, 10 months ago (2016-02-01 21:59:46 UTC) #3
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-02-01 22:05:14 UTC) #4
Karl
4 years, 10 months ago (2016-02-01 22:40:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
c048712807db0daef403735bfb4fa0cb4bd0aff2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698