Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 150203015: Split out InputMethodMenuManager from InputMethodManager (Closed)

Created:
6 years, 10 months ago by Junichi Uekawa
Modified:
6 years, 10 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, nkostylev+watch_chromium.org, plundblad+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, dmazzoni+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, dtseng+watch_chromium.org, nona+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Split out InputMethodMenuManager from InputMethodManager. Rename input_method_property to input_method_menu_item, and move to ash/ime. BUG=342336, 343044 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251164

Patch Set 1 #

Patch Set 2 : does not crash on startup #

Patch Set 3 : unit_tests passes #

Patch Set 4 : fill in unit test #

Patch Set 5 : fix browser test #

Patch Set 6 : make clang happy #

Total comments: 6

Patch Set 7 : reflect review comments #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -320 lines) Patch
M ash/ash.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
A + ash/ime/input_method_menu_item.h View 1 2 3 4 5 6 2 chunks +16 lines, -16 lines 0 comments Download
A + ash/ime/input_method_menu_item.cc View 3 chunks +11 lines, -11 lines 0 comments Download
A ash/ime/input_method_menu_item_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download
A ash/ime/input_method_menu_manager.h View 1 2 3 4 5 1 chunk +64 lines, -0 lines 0 comments Download
A ash/ime/input_method_menu_manager.cc View 1 2 3 4 5 1 chunk +77 lines, -0 lines 0 comments Download
A ash/ime/input_method_menu_manager_unittest.cc View 1 2 3 4 5 6 1 chunk +89 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/input_method_event_router.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/accessibility.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/accessibility.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.h View 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.h View 4 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 6 chunks +18 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl_unittest.cc View 1 2 10 chunks +51 lines, -44 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_persistence.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_engine.h View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.h View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/chromeos/input_method/mock_input_method_manager.cc View 1 2 2 chunks +1 line, -10 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_controller.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 1 2 3 4 5 6 6 chunks +15 lines, -11 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +0 lines, -3 lines 0 comments Download
M chromeos/ime/input_method_manager.h View 4 chunks +1 line, -11 lines 0 comments Download
D chromeos/ime/input_method_property.h View 1 chunk +0 lines, -44 lines 0 comments Download
D chromeos/ime/input_method_property.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D chromeos/ime/input_method_property_unittest.cc View 1 chunk +0 lines, -31 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Junichi Uekawa
Hi, Can you take a look at: derat: chrome/browser/ui/ash/system_tray_delegate_chromeos.cc nona: the rest.
6 years, 10 months ago (2014-02-12 11:03:31 UTC) #1
Seigo Nonaka
lgtm Thank you for cleaning up! https://codereview.chromium.org/150203015/diff/360001/ash/ime/input_method_menu_item.h File ash/ime/input_method_menu_item.h (right): https://codereview.chromium.org/150203015/diff/360001/ash/ime/input_method_menu_item.h#newcode1 ash/ime/input_method_menu_item.h:1: // Copyright 2013 ...
6 years, 10 months ago (2014-02-12 13:12:54 UTC) #2
Daniel Erat
lgtm for chrome/browser/ui/ash after one comment is addressed https://codereview.chromium.org/150203015/diff/360001/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc File chrome/browser/ui/ash/system_tray_delegate_chromeos.cc (right): https://codereview.chromium.org/150203015/diff/360001/chrome/browser/ui/ash/system_tray_delegate_chromeos.cc#newcode303 chrome/browser/ui/ash/system_tray_delegate_chromeos.cc:303: ash::ime::InputMethodMenuManager::Get()->AddObserver(this); ...
6 years, 10 months ago (2014-02-12 15:17:35 UTC) #3
Junichi Uekawa
thanks for the review! https://codereview.chromium.org/150203015/diff/360001/ash/ime/input_method_menu_item.h File ash/ime/input_method_menu_item.h (right): https://codereview.chromium.org/150203015/diff/360001/ash/ime/input_method_menu_item.h#newcode1 ash/ime/input_method_menu_item.h:1: // Copyright 2013 The Chromium ...
6 years, 10 months ago (2014-02-12 22:19:52 UTC) #4
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-13 01:05:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/150203015/940001
6 years, 10 months ago (2014-02-13 01:05:56 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 02:02:37 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=262976
6 years, 10 months ago (2014-02-13 02:02:38 UTC) #8
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-13 03:38:08 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/150203015/940001
6 years, 10 months ago (2014-02-13 03:40:16 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 15:00:28 UTC) #11
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 10 months ago (2014-02-13 15:00:30 UTC) #12
Junichi Uekawa
The CQ bit was checked by uekawa@chromium.org
6 years, 10 months ago (2014-02-13 21:19:23 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/uekawa@chromium.org/150203015/940001
6 years, 10 months ago (2014-02-13 21:23:39 UTC) #14
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 22:46:21 UTC) #15
Message was sent while issue was closed. 
Change committed as 251164

Powered by Google App Engine
This is Rietveld 408576698