Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1654263004: Call RecordWriteIntoCode when storing the target object in the reloc info on ARM and MIPS. (Closed)

Created:
4 years, 10 months ago by Hannes Payer (out of office)
Modified:
4 years, 10 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Call RecordWriteIntoCode when storing the target object in the reloc info on ARM and MIPS. BUG=chromium:561449 LOG=n Committed: https://crrev.com/44ec23ac5fa028099742f3070b7ad86d0d1274c0 Cr-Commit-Position: refs/heads/master@{#33687}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/arm/assembler-arm-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/assembler-mips-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/assembler-mips64-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
ulan
lgtm
4 years, 10 months ago (2016-02-02 15:13:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654263004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654263004/20001
4 years, 10 months ago (2016-02-02 15:19:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1654263004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1654263004/20001
4 years, 10 months ago (2016-02-02 15:36:04 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-02 15:39:07 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 15:39:45 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/44ec23ac5fa028099742f3070b7ad86d0d1274c0
Cr-Commit-Position: refs/heads/master@{#33687}

Powered by Google App Engine
This is Rietveld 408576698