Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Side by Side Diff: src/arm64/assembler-arm64-inl.h

Issue 1654263004: Call RecordWriteIntoCode when storing the target object in the reloc info on ARM and MIPS. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/arm/assembler-arm-inl.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_ARM64_ASSEMBLER_ARM64_INL_H_ 5 #ifndef V8_ARM64_ASSEMBLER_ARM64_INL_H_
6 #define V8_ARM64_ASSEMBLER_ARM64_INL_H_ 6 #define V8_ARM64_ASSEMBLER_ARM64_INL_H_
7 7
8 #include "src/arm64/assembler-arm64.h" 8 #include "src/arm64/assembler-arm64.h"
9 #include "src/assembler.h" 9 #include "src/assembler.h"
10 #include "src/debug/debug.h" 10 #include "src/debug/debug.h"
(...skipping 713 matching lines...) Expand 10 before | Expand all | Expand 10 after
724 void RelocInfo::set_target_object(Object* target, 724 void RelocInfo::set_target_object(Object* target,
725 WriteBarrierMode write_barrier_mode, 725 WriteBarrierMode write_barrier_mode,
726 ICacheFlushMode icache_flush_mode) { 726 ICacheFlushMode icache_flush_mode) {
727 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT); 727 DCHECK(IsCodeTarget(rmode_) || rmode_ == EMBEDDED_OBJECT);
728 Assembler::set_target_address_at(isolate_, pc_, host_, 728 Assembler::set_target_address_at(isolate_, pc_, host_,
729 reinterpret_cast<Address>(target), 729 reinterpret_cast<Address>(target),
730 icache_flush_mode); 730 icache_flush_mode);
731 if (write_barrier_mode == UPDATE_WRITE_BARRIER && 731 if (write_barrier_mode == UPDATE_WRITE_BARRIER &&
732 host() != NULL && 732 host() != NULL &&
733 target->IsHeapObject()) { 733 target->IsHeapObject()) {
734 host()->GetHeap()->incremental_marking()->RecordWrite( 734 host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(
735 host(), &Memory::Object_at(pc_), HeapObject::cast(target)); 735 host(), this, HeapObject::cast(target));
736 } 736 }
737 } 737 }
738 738
739 739
740 Address RelocInfo::target_external_reference() { 740 Address RelocInfo::target_external_reference() {
741 DCHECK(rmode_ == EXTERNAL_REFERENCE); 741 DCHECK(rmode_ == EXTERNAL_REFERENCE);
742 return Assembler::target_address_at(pc_, host_); 742 return Assembler::target_address_at(pc_, host_);
743 } 743 }
744 744
745 745
(...skipping 510 matching lines...) Expand 10 before | Expand all | Expand 10 after
1256 1256
1257 void Assembler::ClearRecordedAstId() { 1257 void Assembler::ClearRecordedAstId() {
1258 recorded_ast_id_ = TypeFeedbackId::None(); 1258 recorded_ast_id_ = TypeFeedbackId::None();
1259 } 1259 }
1260 1260
1261 1261
1262 } // namespace internal 1262 } // namespace internal
1263 } // namespace v8 1263 } // namespace v8
1264 1264
1265 #endif // V8_ARM64_ASSEMBLER_ARM64_INL_H_ 1265 #endif // V8_ARM64_ASSEMBLER_ARM64_INL_H_
OLDNEW
« no previous file with comments | « src/arm/assembler-arm-inl.h ('k') | src/mips/assembler-mips-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698