content/browser/accessibility/browser_accessibility_manager_android.cc - Issue 1654193002: Include a role description string in node info for Android accessibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_manager_android.cc

Issue 1654193002: Include a role description string in node info for Android accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update all Android test expectations Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_manager_android.cc

diff --git a/content/browser/accessibility/browser_accessibility_manager_android.cc b/content/browser/accessibility/browser_accessibility_manager_android.cc

index 57dd100c5713f7ad6126bf008f19c72266199715..75278ac90f9e716f850aaefa6612c061a5ff06a0 100644

--- a/content/browser/accessibility/browser_accessibility_manager_android.cc

+++ b/content/browser/accessibility/browser_accessibility_manager_android.cc

@@ -332,6 +332,11 @@ jboolean BrowserAccessibilityManagerAndroid::PopulateAccessibilityNodeInfo(

absolute_rect.width(), absolute_rect.height(),

is_root);

+ Java_BrowserAccessibilityManager_setAccessibilityNodeInfoKitKatAttributes(

+ env, obj, info,

+ base::android::ConvertUTF16ToJavaString(

+ env, node->GetRoleDescription()).obj());

Java_BrowserAccessibilityManager_setAccessibilityNodeInfoLollipopAttributes(

env, obj, info,

node->CanOpenPopup(),