content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 1654193002: Include a role description string in node info for Android accessibility.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 1654193002: Include a role description string in node info for Android accessibility. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update all Android test expectations Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_android.cc ('k') | content/browser/accessibility/browser_accessibility_manager_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index f8a9aff2594bfcd3dd45a83e3d4285103d23608e..6d0619dcc6f5c4d41fd1b4c1b6a2e366ec13a1f6 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -1017,13 +1017,13 @@ bool InitializeAccessibilityTreeSearch(

IDS_AX_ROLE_COMPLEMENTARY));

case ui::AX_ROLE_CONTENT_INFO:

return base::SysUTF16ToNSString(content_client->GetLocalizedString(

- IDS_AX_ROLE_ADDRESS));

+ IDS_AX_ROLE_CONTENT_INFO));

case ui::AX_ROLE_DESCRIPTION_LIST:

return base::SysUTF16ToNSString(content_client->GetLocalizedString(

IDS_AX_ROLE_DESCRIPTION_LIST));

case ui::AX_ROLE_DESCRIPTION_LIST_DETAIL:

return base::SysUTF16ToNSString(content_client->GetLocalizedString(

- IDS_AX_ROLE_DESCRIPTION_DETAIL));

+ IDS_AX_ROLE_DEFINITION));

case ui::AX_ROLE_DESCRIPTION_LIST_TERM:

return base::SysUTF16ToNSString(content_client->GetLocalizedString(

IDS_AX_ROLE_DESCRIPTION_TERM));