third_party/WebKit/Source/core/editing/FrameSelection.h - Issue 1654123002: Invalidate the previous caret even if the parent text node is removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 1654123002: Invalidate the previous caret even if the parent text node is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add FrameSelectionTest.InvalidatePreviousCaretAfterRemovingLastCharacter Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/ManualTests/caret-paint-after-last-text-is-removed.html ('K') | « third_party/WebKit/ManualTests/caret-paint-after-last-text-is-removed.html ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/FrameSelection.h

diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h

index 7ae465cda55a0e2d1333347929d9ce3b57d216f6..a6dcd683a9c31254696701ba01c539bedda23bf2 100644

--- a/third_party/WebKit/Source/core/editing/FrameSelection.h

+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h

@@ -188,7 +188,6 @@ public:

void scheduleVisualUpdate() const;

void invalidateCaretRect();

void paintCaret(GraphicsContext&, const LayoutPoint&);

- bool ShouldPaintCaretForTesting() const { return m_shouldPaintCaret; }

// Used to suspend caret blinking while the mouse is down.

void setCaretBlinkingSuspended(bool suspended) { m_isCaretBlinkingSuspended = suspended; }

@@ -287,6 +286,10 @@ private:

GranularityStrategy* granularityStrategy();

+ // For unittests

+ bool ShouldPaintCaretForTesting() const { return m_shouldPaintCaret; }

+ bool isPreviousCaretDirtyForTesting() const { return m_previousCaretNode; }

RawPtrWillBeMember<LocalFrame> m_frame;

const OwnPtrWillBeMember<PendingSelection> m_pendingSelection;

const OwnPtrWillBeMember<SelectionEditor> m_selectionEditor;