Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 1654123002: Invalidate the previous caret even if the parent text node is removed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add FrameSelectionTest.InvalidatePreviousCaretAfterRemovingLastCharacter Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index fd90957a58fd8df90dcd66039ffb75dd0e540789..9a0978b271c82254d50945b68a0b4dc9db1999fd 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -405,6 +405,15 @@ void FrameSelection::nodeWillBeRemoved(Node& node)
respondToNodeModification(node, removingNodeRemovesPosition(node, selection().base()), removingNodeRemovesPosition(node, selection().extent()),
removingNodeRemovesPosition(node, selection().start()), removingNodeRemovesPosition(node, selection().end()));
+
+ if (node == m_previousCaretNode) {
+ // Hits in ManualTests/caret-paint-after-last-text-is-removed.html
+ DisableCompositingQueryAsserts disabler;
+ invalidateLocalCaretRect(m_previousCaretNode.get(), m_previousCaretRect);
+ m_previousCaretNode = nullptr;
+ m_previousCaretRect = LayoutRect();
+ m_previousCaretVisibility = Hidden;
+ }
}
static bool intersectsNode(const VisibleSelection& selection, Node* node)

Powered by Google App Engine
This is Rietveld 408576698