Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1653973005: Make dynamic_annotations build with -Wconstant-conversion from newer clangs. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make dynamic_annotations build with -Wconstant-conversion from newer clangs. After http://llvm.org/viewvc/llvm-project?rev=259271&view=rev, clang points out that lineno is sometimes assigned a value > SHRT_MAX, which causes an overflow. All values are smaller than USHRT_MAX, so just make lineno an unsigned short. No behavior change. BUG=none Committed: https://crrev.com/6ef06b461ccae125f8c8d6e33dde10c550ff3780 Cr-Commit-Position: refs/heads/master@{#372952}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M base/third_party/dynamic_annotations/README.chromium View 1 chunk +3 lines, -0 lines 0 comments Download
M base/third_party/dynamic_annotations/dynamic_annotations.c View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Nico
4 years, 10 months ago (2016-02-02 14:53:14 UTC) #2
Alexander Potapenko
On 2016/02/02 14:53:14, Nico wrote: Well, at least for third_party/sqlite/amalgamation/sqlite3.c the number of lines does ...
4 years, 10 months ago (2016-02-02 15:02:31 UTC) #3
Nico
This is a .c file, not a .h file (?)
4 years, 10 months ago (2016-02-02 15:03:04 UTC) #4
Alexander Potapenko
On 2016/02/02 15:02:31, Alexander Potapenko wrote: > On 2016/02/02 14:53:14, Nico wrote: > > Well, ...
4 years, 10 months ago (2016-02-02 15:03:37 UTC) #5
Alexander Potapenko
Oh, sorry, you are right. LGTM
4 years, 10 months ago (2016-02-02 15:04:31 UTC) #6
Alexander Potapenko
Oh, sorry, you are right. LGTM
4 years, 10 months ago (2016-02-02 15:04:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653973005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653973005/1
4 years, 10 months ago (2016-02-02 15:07:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-02 16:00:34 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-02 16:01:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ef06b461ccae125f8c8d6e33dde10c550ff3780
Cr-Commit-Position: refs/heads/master@{#372952}

Powered by Google App Engine
This is Rietveld 408576698