base/third_party/dynamic_annotations/README.chromium - Issue 1653973005: Make dynamic_annotations build with -Wconstant-conversion from newer clangs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: base/third_party/dynamic_annotations/README.chromium

Issue 1653973005: Make dynamic_annotations build with -Wconstant-conversion from newer clangs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | base/third_party/dynamic_annotations/dynamic_annotations.c » ('j') | no next file with comments »

OLD	NEW
1 Name: dynamic annotations	1 Name: dynamic annotations

2 URL: http://code.google.com/p/data-race-test/wiki/DynamicAnnotations	2 URL: http://code.google.com/p/data-race-test/wiki/DynamicAnnotations

3 Version: 4384	3 Version: 4384

4 License: BSD	4 License: BSD

5	5

6 ATTENTION: please avoid using these annotations in Chromium code.	6 ATTENTION: please avoid using these annotations in Chromium code.

7 They were mainly intended to instruct the Valgrind-based version of	7 They were mainly intended to instruct the Valgrind-based version of

8 ThreadSanitizer to handle atomic operations. The new version of ThreadSanitizer	8 ThreadSanitizer to handle atomic operations. The new version of ThreadSanitizer

9 based on compiler instrumentation understands atomic operations out of the box,	9 based on compiler instrumentation understands atomic operations out of the box,

10 so normally you don't need the annotations.	10 so normally you don't need the annotations.

11 If you still think you do, please consider writing a comment at http://crbug.com /349861	11 If you still think you do, please consider writing a comment at http://crbug.com /349861

12	12

13 One header and one source file (dynamic_annotations.h and dynamic_annotations.c)	13 One header and one source file (dynamic_annotations.h and dynamic_annotations.c)

14 in this directory define runtime macros useful for annotating synchronization	14 in this directory define runtime macros useful for annotating synchronization

15 utilities and benign data races so data race detectors can handle Chromium code	15 utilities and benign data races so data race detectors can handle Chromium code

16 with better precision.	16 with better precision.

17	17

18 These files were taken from	18 These files were taken from

19 http://code.google.com/p/data-race-test/source/browse/?#svn/trunk/dynamic_annota tions	19 http://code.google.com/p/data-race-test/source/browse/?#svn/trunk/dynamic_annota tions

20 The files are covered under BSD license as described within the files.	20 The files are covered under BSD license as described within the files.

	21

	22 Local modifications:

	23 * made lineno an unsigned short (for -Wconstant-conversion warning fixes)

OLD	NEW