Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 165393010: Draft: Moving code out of ProfileSyncServiceHarness (Closed)

Created:
6 years, 10 months ago by rlarocque
Modified:
6 years, 8 months ago
Reviewers:
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Draft: Moving code out of ProfileSyncServiceHarness NOT FOR COMMIT. This is for review purposes only. This continues the integration test refactoring. It upgrades the StatusChangeChecker with new features. It uses those new features to pull code out of the ProfileSyncServiceHarness. I think this proves that the ProfileSyncServiceHarness can be eliminated entirely. Here are some of the advantages we gain from these changes: - Configurable timeout intervals. - Better debug messages. - AwaitQuiescence is now stateless. - All other multi-client Await functions replaced with AwaitQuiescence. With a bit more work, we can move the remaining functions out of the ProfileSyncServiceHarness. Once that's done, we can start to replace the generic progress-marker based Await functions with more specific wait funcitons. BUG=323380

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -310 lines) Patch
M chrome/browser/sync/test/integration/migration_test.cc View 5 chunks +13 lines, -5 lines 0 comments Download
chrome/browser/sync/test/integration/multi_client_status_change_checker.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/sync/test/integration/multi_client_status_change_checker.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/sync/test/integration/p2p_invalidation_forwarder.h View 1 chunk +40 lines, -0 lines 0 comments Download
chrome/browser/sync/test/integration/p2p_invalidation_forwarder.cc View 1 chunk +36 lines, -0 lines 0 comments Download
chrome/browser/sync/test/integration/profile_sync_service_harness.h View 10 chunks +7 lines, -34 lines 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 13 chunks +57 lines, -202 lines 0 comments Download
chrome/browser/sync/test/integration/quiesce_status_change_checker.h View 1 chunk +31 lines, -0 lines 0 comments Download
chrome/browser/sync/test/integration/quiesce_status_change_checker.cc View 1 chunk +100 lines, -0 lines 0 comments Download
chrome/browser/sync/test/integration/single_client_status_change_checker.h View 1 chunk +33 lines, -0 lines 0 comments Download
chrome/browser/sync/test/integration/single_client_status_change_checker.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/status_change_checker.h View 2 chunks +28 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/status_change_checker.cc View 1 chunk +92 lines, -3 lines 0 comments Download
chrome/browser/sync/test/integration/sync_auth_test.cc View 3 chunks +11 lines, -9 lines 0 comments Download
chrome/browser/sync/test/integration/sync_errors_test.cc View 3 chunks +10 lines, -12 lines 0 comments Download
chrome/browser/sync/test/integration/sync_exponential_backoff_test.cc View 5 chunks +19 lines, -17 lines 0 comments Download
chrome/browser/sync/test/integration/sync_test.h View 2 chunks +0 lines, -7 lines 0 comments Download
chrome/browser/sync/test/integration/sync_test.cc View 3 chunks +1 line, -15 lines 0 comments Download
chrome/chrome_tests.gypi View 1 chunk +8 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698