Draft: Moving code out of ProfileSyncServiceHarness

chrome/browser/sync/test/integration/migration_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/compiler_specific.h"
 #include "base/memory/scoped_vector.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sync/backend_migrator.h"
 #include "chrome/browser/sync/test/integration/bookmarks_helper.h"
 #include "chrome/browser/sync/test/integration/preferences_helper.h"
 #include "chrome/browser/sync/test/integration/profile_sync_service_harness.h"
-#include "chrome/browser/sync/test/integration/status_change_checker.h"
+#include "chrome/browser/sync/test/integration/single_client_status_change_checker.h"
 #include "chrome/browser/sync/test/integration/sync_test.h"
 #include "chrome/browser/translate/translate_prefs.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/base/ui_test_utils.h"
 
 using bookmarks_helper::AddURL;
 using bookmarks_helper::IndexedURL;
 using bookmarks_helper::IndexedURLTitle;
 
 using preferences_helper::BooleanPrefMatches;
@@ skipping 36 matching lines @@
   return MakeList(MakeSet(type));
 }
 
 MigrationList MakeList(syncer::ModelType type1,
                        syncer::ModelType type2) {
   return MakeList(MakeSet(type1), MakeSet(type2));
 }
 
 // Helper class that checks if the sync backend has successfully completed
 // migration for a set of data types.
-class MigrationChecker : public StatusChangeChecker,
+class MigrationChecker : public SingleClientStatusChangeChecker,
                          public browser_sync::MigrationObserver {
  public:
   explicit MigrationChecker(ProfileSyncServiceHarness* harness)
-      : StatusChangeChecker("MigrationChecker"),
+      : SingleClientStatusChangeChecker(harness->service()),
         harness_(harness) {
     DCHECK(harness_);
     browser_sync::BackendMigrator* migrator =
         harness_->service()->GetBackendMigratorForTest();
     // PSS must have a migrator after sync is setup and initial data type
     // configuration is complete.
     DCHECK(migrator);
     migrator->AddMigrationObserver(this);
   }
 
   virtual ~MigrationChecker() {}
 
   // Returns true when sync reports that there is no pending migration, and
   // migration is complete for all data types in |expected_types_|.
   virtual bool IsExitConditionSatisfied() OVERRIDE {
     DCHECK(!expected_types_.Empty());
     bool all_expected_types_migrated = migrated_types_.HasAll(expected_types_);
     DVLOG(1) << harness_->profile_debug_name() << ": Migrated types "
              << syncer::ModelTypeSetToString(migrated_types_)
              << (all_expected_types_migrated ? " contains " :
                                                " does not contain ")
              << syncer::ModelTypeSetToString(expected_types_);
     return all_expected_types_migrated &&
            !HasPendingBackendMigration();
   }
 
+  virtual std::string GetDebugMessage() const OVERRIDE {
+    return "Waiting to migrate (" + ModelTypeSetToString(expected_types_) + ")";
+  }
+
   bool HasPendingBackendMigration() const {
     browser_sync::BackendMigrator* migrator =
         harness_->service()->GetBackendMigratorForTest();
     return migrator && migrator->state() != browser_sync::BackendMigrator::IDLE;
   }
 
   void set_expected_types(syncer::ModelTypeSet expected_types) {
     expected_types_ = expected_types;
   }
 
@@ skipping 13 matching lines @@
                << syncer::ModelTypeSetToString(pending_types_);
     } else {
       // Migration just finished for a bunch of data types. Merge them into
       // |migrated_types_|.
       migrated_types_.PutAll(pending_types_);
       pending_types_.Clear();
       DVLOG(1) << harness_->profile_debug_name() << ": new migrated types "
                << syncer::ModelTypeSetToString(migrated_types_);
     }
 
+#if 0
     // Nudge ProfileSyncServiceHarness to inspect the exit condition provided by
     // AwaitMigration.
-    harness_->OnStateChanged();
+    if (IsWaiting() && IsExitConditionSatisfied()) {
+      StopWaitingAndSucceed();
+    }
+#endif
   }
 
  private:
   // The sync client for which migration is being verified.
   ProfileSyncServiceHarness* harness_;
 
   // The set of data types that are expected to eventually undergo migration.
   syncer::ModelTypeSet expected_types_;
 
   // The set of data types currently undergoing migration.
@@ skipping 80 matching lines @@
     }
   }
 
   // Block until all clients have completed migration for the given
   // types.
   void AwaitMigration(syncer::ModelTypeSet migrate_types) {
     for (int i = 0; i < num_clients(); ++i) {
       MigrationChecker* checker = migration_checkers_[i];
       checker->set_expected_types(migrate_types);
       if (!checker->IsExitConditionSatisfied())
-        ASSERT_TRUE(GetClient(i)->AwaitStatusChange(checker, "AwaitMigration"));
+        ASSERT_TRUE(GetClient(i)->AwaitStatusChange(checker));
     }
   }
 
   bool ShouldRunMigrationTest() const {
     if (!ServerSupportsNotificationControl() ||
         !ServerSupportsErrorTriggering()) {
       LOG(WARNING) << "Test skipped in this server environment.";
       return false;
     }
     return true;
@@ skipping 268 matching lines @@
     // Do not add optional datatypes.
   }
 
   virtual ~MigrationReconfigureTest() {}
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MigrationReconfigureTest);
 };
 
 }  // namespace