Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 16539003: Revert 205057 "Add JSON.pm to third_party" (Closed)

Created:
7 years, 6 months ago by cpu_(ooo_6.6-7.5)
Modified:
7 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 205057 "Add JSON.pm to third_party" It broke the check_perms check in ChromiumOS, FAILED /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/eg/bench_decode.pl: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/eg/bench_encode.pl: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/t/19_incr.t: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/t/20_unknown.t: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/t/e02_bool.t: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/t/e13_overloaded_eq.t: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/t/e14_decode_prefix.t: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/t/e16_incr_parse_fixed.t: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/t/e90_misc.t: Has shebang but not executable bit /b/build/slave/Linux_ChromiumOS/build/src/third_party/JSON/JSON-2.59/t/xe02_bool.t: Has shebang but not executable bit > Add JSON.pm to third_party > > We're using JSON as an exchange format both: > 1. To make the existing Perl more modular > (so we can connect the parser and code generator via intermediate files), > 2. To ease porting to Python, so we can connect existing Perl scripts > to new Python scripts. > > This is build-only: the module is used during the build, but not included > in the distributed binary, and thus should not pose licensing problems. > > Source: http://www.cpan.org/authors/id/M/MA/MAKAMAKA/JSON-2.59.tar.gz > SHA-1: 8a82c442088ffa0d605747fd5e65f51e037aad94 > > License is same as Perl, meaning GPL v1+ or Artistic license: > http://search.cpan.org/~makamaka/JSON-2.58/lib/JSON.pm#COPYRIGHT_AND_LICENSE > http://dev.perl.org/licenses/ > > BUG=239771 > > Review URL: https://chromiumcodereview.appspot.com/15736030 TBR=nbarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=205061

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -30606 lines) Patch
D trunk/src/third_party/JSON/JSON-2.59.tar.gz.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/Changes View 1 chunk +0 lines, -372 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/MANIFEST View 1 chunk +0 lines, -71 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/META.json View 1 chunk +0 lines, -49 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/META.yml View 1 chunk +0 lines, -26 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/MYMETA.yml View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/Makefile View 1 chunk +0 lines, -823 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/Makefile.PL View 1 chunk +0 lines, -77 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/README View 1 chunk +0 lines, -1566 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/lib/JSON.pm View 1 chunk +0 lines, -2292 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/lib/JSON/backportPP.pm View 1 chunk +0 lines, -2803 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/lib/JSON/backportPP/Boolean.pm View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/lib/JSON/backportPP/Compat5005.pm View 1 chunk +0 lines, -131 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/lib/JSON/backportPP/Compat5006.pm View 1 chunk +0 lines, -173 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/man3/JSON.3pm View 1 chunk +0 lines, -1876 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/man3/JSON__backportPP.3pm View 1 chunk +0 lines, -1379 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/man3/JSON__backportPP__Boolean.3pm View 1 chunk +0 lines, -146 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/man3/JSON__backportPP__Compat5005.3pm View 1 chunk +0 lines, -145 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/blib/man3/JSON__backportPP__Compat5006.3pm View 1 chunk +0 lines, -145 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/eg/bench_decode.pl View 1 chunk +0 lines, -70 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/eg/bench_encode.pl View 1 chunk +0 lines, -86 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/lib/JSON.pm View 1 chunk +0 lines, -2292 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/lib/JSON/backportPP.pm View 1 chunk +0 lines, -2803 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/lib/JSON/backportPP/Boolean.pm View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/lib/JSON/backportPP/Compat5005.pm View 1 chunk +0 lines, -131 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/lib/JSON/backportPP/Compat5006.pm View 1 chunk +0 lines, -173 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/00_load.t View 1 chunk +0 lines, -15 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/00_pod.t View 1 chunk +0 lines, -8 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/01_utf8.t View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/02_error.t View 1 chunk +0 lines, -51 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/03_types.t View 1 chunk +0 lines, -60 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/06_pc_pretty.t View 1 chunk +0 lines, -69 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/07_pc_esc.t View 1 chunk +0 lines, -93 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/08_pc_base.t View 1 chunk +0 lines, -99 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/09_pc_extra_number.t View 1 chunk +0 lines, -39 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/10_pc_keysort.t View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/11_pc_expo.t View 1 chunk +0 lines, -47 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/12_blessed.t View 1 chunk +0 lines, -53 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/13_limit.t View 1 chunk +0 lines, -34 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/14_latin1.t View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/15_prefix.t View 1 chunk +0 lines, -16 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/16_tied.t View 1 chunk +0 lines, -23 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/17_relaxed.t View 1 chunk +0 lines, -30 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/18_json_checker.t View 1 chunk +0 lines, -175 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/19_incr.t View 1 chunk +0 lines, -183 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/20_unknown.t View 1 chunk +0 lines, -55 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/21_evans_bugrep.t View 1 chunk +0 lines, -50 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/22_comment_at_eof.t View 1 chunk +0 lines, -47 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/99_binary.t View 1 chunk +0 lines, -53 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/_unicode_handling.pm View 1 chunk +0 lines, -28 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e00_func.t View 1 chunk +0 lines, -17 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e01_property.t View 1 chunk +0 lines, -67 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e02_bool.t View 1 chunk +0 lines, -33 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e03_bool2.t View 1 chunk +0 lines, -43 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e04_sortby.t View 1 chunk +0 lines, -24 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e05_esc_slash.t View 1 chunk +0 lines, -15 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e06_allow_barekey.t View 1 chunk +0 lines, -19 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e07_allow_singlequote.t View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e08_decode.t View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e09_encode.t View 1 chunk +0 lines, -39 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e10_bignum.t View 1 chunk +0 lines, -41 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e11_conv_blessed_univ.t View 1 chunk +0 lines, -45 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e12_upgrade.t View 1 chunk +0 lines, -32 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e13_overloaded_eq.t View 1 chunk +0 lines, -66 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e14_decode_prefix.t View 1 chunk +0 lines, -29 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e15_tie_ixhash.t View 1 chunk +0 lines, -44 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e16_incr_parse_fixed.t View 1 chunk +0 lines, -29 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/e90_misc.t View 1 chunk +0 lines, -19 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/x00_load.t View 1 chunk +0 lines, -14 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/x02_error.t View 1 chunk +0 lines, -61 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/x12_blessed.t View 1 chunk +0 lines, -54 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/x16_tied.t View 1 chunk +0 lines, -26 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/x17_strange_overload.t View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe01_property.t View 1 chunk +0 lines, -56 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe02_bool.t View 1 chunk +0 lines, -34 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe03_bool2.t View 1 chunk +0 lines, -47 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe04support_by_pp.t View 1 chunk +0 lines, -22 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe05_indent_length.t View 1 chunk +0 lines, -76 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe08_decode.t View 1 chunk +0 lines, -45 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe10_bignum.t View 1 chunk +0 lines, -36 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe11_conv_blessed_univ.t View 1 chunk +0 lines, -48 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe12_boolean.t View 1 chunk +0 lines, -35 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe19_xs_and_suportbypp.t View 1 chunk +0 lines, -34 lines 0 comments Download
D trunk/src/third_party/JSON/JSON-2.59/t/xe20_croak_message.t View 1 chunk +0 lines, -22 lines 0 comments Download
D trunk/src/third_party/JSON/LICENSE View 1 chunk +0 lines, -1092 lines 0 comments Download
D trunk/src/third_party/JSON/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D trunk/src/third_party/JSON/README.chromium View 1 chunk +0 lines, -20 lines 0 comments Download
D trunk/src/third_party/JSON/get_and_build_json_pm.sh View 1 chunk +0 lines, -59 lines 0 comments Download
D trunk/src/third_party/JSON/out/lib/perl5/JSON.pm View 1 chunk +0 lines, -2292 lines 0 comments Download
D trunk/src/third_party/JSON/out/lib/perl5/JSON/backportPP.pm View 1 chunk +0 lines, -2803 lines 0 comments Download
D trunk/src/third_party/JSON/out/lib/perl5/JSON/backportPP/Boolean.pm View 1 chunk +0 lines, -27 lines 0 comments Download
D trunk/src/third_party/JSON/out/lib/perl5/JSON/backportPP/Compat5005.pm View 1 chunk +0 lines, -131 lines 0 comments Download
D trunk/src/third_party/JSON/out/lib/perl5/JSON/backportPP/Compat5006.pm View 1 chunk +0 lines, -173 lines 0 comments Download
D trunk/src/third_party/JSON/out/lib/perl5/x86_64-linux-gnu-thread-multi/auto/JSON/.packlist View 1 chunk +0 lines, -14 lines 0 comments Download
D trunk/src/third_party/JSON/out/lib/perl5/x86_64-linux-gnu-thread-multi/perllocal.pod View 1 chunk +0 lines, -22 lines 0 comments Download
D trunk/src/third_party/JSON/out/man/man3/JSON.3pm View 1 chunk +0 lines, -1876 lines 0 comments Download
D trunk/src/third_party/JSON/out/man/man3/JSON__backportPP.3pm View 1 chunk +0 lines, -1379 lines 0 comments Download
D trunk/src/third_party/JSON/out/man/man3/JSON__backportPP__Boolean.3pm View 1 chunk +0 lines, -146 lines 0 comments Download
D trunk/src/third_party/JSON/out/man/man3/JSON__backportPP__Compat5005.3pm View 1 chunk +0 lines, -145 lines 0 comments Download
D trunk/src/third_party/JSON/out/man/man3/JSON__backportPP__Compat5006.3pm View 1 chunk +0 lines, -145 lines 0 comments Download
M trunk/src/tools/checklicenses/checklicenses.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
cpu_(ooo_6.6-7.5)
7 years, 6 months ago (2013-06-08 15:13:52 UTC) #1
cpu_(ooo_6.6-7.5)
Committed patchset #1 manually as r205061.
7 years, 6 months ago (2013-06-08 15:14:13 UTC) #2
Nils Barth (inactive)
Thanks for fixing this Carlos! I've revised the original CL to fix this. Should some ...
7 years, 6 months ago (2013-06-10 03:53:28 UTC) #3
Nils Barth (inactive)
7 years, 6 months ago (2013-06-10 03:54:02 UTC) #4
Message was sent while issue was closed.
Oh, and FWIW: LGTM

Powered by Google App Engine
This is Rietveld 408576698