third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp b/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

index 89093b2ff0dab50909aad0a8ebd1ce8242a717f1..cb498b86dc1bd48dfd61d72fc629d58e86486696 100644

--- a/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp

@@ -129,7 +129,7 @@ LayoutRect InlineFlowBoxPainter::paintRectForImageStrip(const LayoutPoint& paint

// strip. Even though that strip has been broken up across multiple lines, you still paint it

// as though you had one single line. This means each line has to pick up the background where

// the previous line left off.

- LayoutUnit logicalOffsetOnLine = 0;

+ LayoutUnit logicalOffsetOnLine;

LayoutUnit totalLogicalWidth;

if (direction == LTR) {

for (const InlineFlowBox* curr = m_inlineFlowBox.prevLineBox(); curr; curr = curr->prevLineBox())