third_party/WebKit/Source/core/paint/FrameSetPainter.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/FrameSetPainter.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/FrameSetPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/FrameSetPainter.cpp b/third_party/WebKit/Source/core/paint/FrameSetPainter.cpp

index 3ca3c37049e61e9cfdd3e74ad47e5122e6a220fe..8d73e4304568b41d50117201507b705b1683d526 100644

--- a/third_party/WebKit/Source/core/paint/FrameSetPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/FrameSetPainter.cpp

@@ -82,9 +82,9 @@ void FrameSetPainter::paintBorders(const PaintInfo& paintInfo, const LayoutPoint

LayoutObject* child = m_layoutFrameSet.firstChild();

size_t rows = m_layoutFrameSet.rows().m_sizes.size();

size_t cols = m_layoutFrameSet.columns().m_sizes.size();

- LayoutUnit yPos = 0;

+ LayoutUnit yPos;

for (size_t r = 0; r < rows; r++) {

- LayoutUnit xPos = 0;

+ LayoutUnit xPos;

for (size_t c = 0; c < cols; c++) {

xPos += m_layoutFrameSet.columns().m_sizes[c];

if (shouldPaintBorderAfter(m_layoutFrameSet.columns(), c)) {