third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

index d5c12da2cdad6c98a2e8ff24bb65f5c1dd66ed28..49ca3a8d5be6e9f122b066b1aecb50906453c36f 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp

@@ -388,8 +388,8 @@ void LayoutSVGText::layout()

setLogicalHeight(beforeEdge);

LayoutState state(*this, locationOffset());

- LayoutUnit paintInvalidationLogicalTop = 0;

- LayoutUnit paintInvalidationLogicalBottom = 0;

+ LayoutUnit paintInvalidationLogicalTop;

+ LayoutUnit paintInvalidationLogicalBottom;

layoutInlineChildren(true, paintInvalidationLogicalTop, paintInvalidationLogicalBottom, afterEdge);

if (m_needsReordering)