Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors
Patch Set: address comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
index d87bd1faf0d93441358a3ccd96c0d8b124112f94..acbb83b72942ca4bb8ad86e8ecc1a72a7af58ec7 100644
--- a/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
+++ b/third_party/WebKit/Source/core/layout/line/RootInlineBox.cpp
@@ -134,7 +134,7 @@ LayoutUnit RootInlineBox::placeEllipsis(const AtomicString& ellipsisStr, bool l
// of that glyph. Mark all of the objects that intersect the ellipsis box as not painting (as being
// truncated).
bool foundBox = false;
- LayoutUnit truncatedWidth = 0;
+ LayoutUnit truncatedWidth;
LayoutUnit position = placeEllipsisBox(ltr, blockLeftEdge, blockRightEdge, ellipsisWidth, truncatedWidth, foundBox);
ellipsisBox->setLogicalLeft(position);
return truncatedWidth;
@@ -196,8 +196,8 @@ LayoutUnit RootInlineBox::alignBoxesInBlockDirection(LayoutUnit heightOfBlock, G
if (isSVGRootInlineBox())
return 0;
- LayoutUnit maxPositionTop = 0;
- LayoutUnit maxPositionBottom = 0;
+ LayoutUnit maxPositionTop;
+ LayoutUnit maxPositionBottom;
int maxAscent = 0;
int maxDescent = 0;
bool setMaxAscent = false;
@@ -250,7 +250,7 @@ LayoutUnit RootInlineBox::maxLogicalTop() const
LayoutUnit RootInlineBox::beforeAnnotationsAdjustment() const
{
- LayoutUnit result = 0;
+ LayoutUnit result;
if (!lineLayoutItem().style()->isFlippedLinesWritingMode()) {
// Annotations under the previous line may push us down.
@@ -619,7 +619,7 @@ LayoutUnit RootInlineBox::verticalPositionForBox(InlineBox* box, VerticalPositio
return verticalPosition;
}
- LayoutUnit verticalPosition = 0;
+ LayoutUnit verticalPosition;
EVerticalAlign verticalAlign = boxModel.style()->verticalAlign();
if (verticalAlign == TOP || verticalAlign == BOTTOM)
return 0;

Powered by Google App Engine
This is Rietveld 408576698