third_party/WebKit/Source/core/layout/LayoutListMarker.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

index 644ae0e917022bc02676ba6c482c56f9bb8fe68b..73f4bbb8e0d2d7e920249a15704fe15036bbf5b6 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListMarker.cpp

@@ -228,7 +228,7 @@ void LayoutListMarker::computePreferredLogicalWidths()

const Font& font = style()->font();

- LayoutUnit logicalWidth = 0;

+ LayoutUnit logicalWidth;

switch (listStyleCategory()) {

case ListStyleCategory::None:

break;

@@ -252,8 +252,8 @@ void LayoutListMarker::updateMargins()

{

const FontMetrics& fontMetrics = style()->fontMetrics();

- LayoutUnit marginStart = 0;

- LayoutUnit marginEnd = 0;

+ LayoutUnit marginStart;

+ LayoutUnit marginEnd;

if (isInside()) {

if (isImage()) {