third_party/WebKit/Source/core/layout/LayoutListItem.cpp - Issue 1653673002: Even more explicit LayoutUnit conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListItem.cpp

Issue 1653673002: Even more explicit LayoutUnit conversion (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@moarConstructors

Patch Set: address comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutListItem.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp

index 93bc76c42892f8d862c242a1e6d7fc0ed1a2c195..ee887575b725bdbfa26216c5f2998284a7a3a3b5 100644

--- a/third_party/WebKit/Source/core/layout/LayoutListItem.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutListItem.cpp

@@ -334,8 +334,8 @@ void LayoutListItem::positionListMarker()

{

if (m_marker && m_marker->parent() && m_marker->parent()->isBox() && !m_marker->isInside() && m_marker->inlineBoxWrapper()) {

LayoutUnit markerOldLogicalLeft = m_marker->logicalLeft();

- LayoutUnit blockOffset = 0;

- LayoutUnit lineOffset = 0;

+ LayoutUnit blockOffset;

+ LayoutUnit lineOffset;

for (LayoutBox* o = m_marker->parentBox(); o != this; o = o->parentBox()) {

blockOffset += o->logicalTop();

lineOffset += o->logicalLeft();