Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1653573003: Revert of Migrate Local Discovery from net::IPAddressNumber to net::IPAddress. (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, devtools-reviews_chromium.org, extensions-reviews_chromium.org, jam, pfeldman, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate Local Discovery from net::IPAddressNumber to net::IPAddress. (patchset #4 id:400001 of https://codereview.chromium.org/1534583002/ ) Reason for revert: Doesn't build on the 'all' builders: ..\..\chrome\tools\service_discovery_sniffer\service_discovery_sniffer.cc(60,26) : error: invalid operands to binary expression ('const net::IPAddress' and 'net::IPAddressNumber' (aka 'vector<unsigned char>')) if (service.ip_address != net::IPAddressNumber()) { ~~~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~ ..\..\chrome\tools\service_discovery_sniffer\service_discovery_sniffer.cc(61,34) : error: no matching function for call to 'IPAddressToString' printf("\tIP Address: %s\n", net::IPAddressToString( ^~~~~~~~~~~~~~~~~~~~~~ ..\..\net/base/ip_address_number.h(51,24) : note: candidate function not viable: no known conversion from 'const net::IPAddress' to 'const IPAddressNumber' (aka 'const vector<unsigned char>') for 1st argument NET_EXPORT std::string IPAddressToString(const IPAddressNumber& addr); ^ ..\..\net/base/ip_address_number.h(41,24) : note: candidate function not viable: requires 2 arguments, but 1 was provided NET_EXPORT std::string IPAddressToString(const uint8_t* address, https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/14840/steps/compile/logs/stdio Original issue's description: > This CL migrates Local Discovery from net::IPAddressNumber to net::IPAddress. > > This CL is part of the net::IPAddressNumber migration[1]. > > BUG=496258 > > [1] https://code.google.com/p/chromium/issues/detail?id=496258#c10 > > Committed: https://crrev.com/aed54d71aad92c60a684f21e30e90bd2f4d9cc7f > Cr-Commit-Position: refs/heads/master@{#372550} TBR=dgozman@chromium.org,eroman@chromium.org,vitalybuka@chromium.org,martijn@martijnc.be # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=496258 Committed: https://crrev.com/ed6b7232e4c771c3136e2ade9339453a2969df5e Cr-Commit-Position: refs/heads/master@{#372551}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -65 lines) Patch
M chrome/browser/devtools/device/cast_device_provider.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/devtools/device/cast_device_provider_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/mdns/dns_sd_device_lister.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/endpoint_resolver.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/endpoint_resolver.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/local_discovery/local_domain_resolver_unittest.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_impl.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mac_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_mdns.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/service_discovery_client_unittest.cc View 3 chunks +12 lines, -9 lines 0 comments Download
M chrome/browser/printing/cloud_print/privet_device_lister_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
Created Revert of Migrate Local Discovery from net::IPAddressNumber to net::IPAddress.
4 years, 10 months ago (2016-01-30 14:58:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653573003/1
4 years, 10 months ago (2016-01-30 14:58:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-30 14:59:35 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-01-30 15:00:22 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed6b7232e4c771c3136e2ade9339453a2969df5e
Cr-Commit-Position: refs/heads/master@{#372551}

Powered by Google App Engine
This is Rietveld 408576698