chrome/browser/devtools/device/cast_device_provider_unittest.cc - Issue 1653573003: Revert of Migrate Local Discovery from net::IPAddressNumber to net::IPAddress.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/device/cast_device_provider_unittest.cc

Issue 1653573003: Revert of Migrate Local Discovery from net::IPAddressNumber to net::IPAddress. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/device/cast_device_provider.cc ('k') | chrome/browser/extensions/api/mdns/dns_sd_device_lister.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/device/cast_device_provider_unittest.cc

diff --git a/chrome/browser/devtools/device/cast_device_provider_unittest.cc b/chrome/browser/devtools/device/cast_device_provider_unittest.cc

index e713b71b77cf283eb8823c569564ab9c20f0ab4b..7e0daec57a945c7bd34ed5cdebeeeb8993815d27 100644

--- a/chrome/browser/devtools/device/cast_device_provider_unittest.cc

+++ b/chrome/browser/devtools/device/cast_device_provider_unittest.cc

@@ -6,7 +6,6 @@

#include "chrome/browser/devtools/device/android_device_manager.h"

#include "net/base/host_port_pair.h"

-#include "net/base/ip_address.h"

#include "testing/gtest/include/gtest/gtest.h"

using local_discovery::ServiceDescription;

@@ -51,8 +50,7 @@

cast_service.metadata.push_back("id=0123456789abcdef0123456789abcdef");

cast_service.metadata.push_back("ve=00");

cast_service.metadata.push_back("md=" + cast_service_model);

- ASSERT_TRUE(

- net::IPAddress::FromIPLiteral("192.168.1.101", &cast_service.ip_address));

+ cast_service.ip_address = {192, 168, 1, 101};

device_provider_->OnDeviceChanged(true, cast_service);

@@ -86,8 +84,7 @@

other_service.metadata.push_back("id=0123456789abcdef0123456789abcdef");

other_service.metadata.push_back("ve=00");

other_service.metadata.push_back("md=" + other_service_model);

- ASSERT_TRUE(

- net::IPAddress::FromIPLiteral("10.64.1.101", &other_service.ip_address));

+ other_service.ip_address = {10, 64, 1, 101};

// Callback should not be run, since this service is not yet discovered.

device_provider_->QueryDeviceInfo(other_service.address.host(),