Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1653423002: Add the data parameter back to the access check callback (Closed)

Created:
4 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 10 months ago
Reviewers:
Toon Verwaest
CC:
Paweł Hajdan Jr., v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add the data parameter back to the access check callback BUG=none R=verwaest@chromium.org LOG=n Committed: https://crrev.com/a75b2c8f69634685288b419c8b4daf2d661b4bf4 Cr-Commit-Position: refs/heads/master@{#33699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -21 lines) Patch
M include/v8.h View 2 chunks +8 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-api.cc View 6 chunks +14 lines, -10 lines 0 comments Download
M test/cctest/test-api-interceptors.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-object-observe.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
4 years, 10 months ago (2016-02-02 16:01:50 UTC) #1
jochen (gone - plz use gerrit)
ptal
4 years, 10 months ago (2016-02-03 07:40:53 UTC) #2
Toon Verwaest
lgtm
4 years, 10 months ago (2016-02-03 09:53:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1653423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1653423002/1
4 years, 10 months ago (2016-02-03 10:00:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-03 10:02:30 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-03 10:02:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a75b2c8f69634685288b419c8b4daf2d661b4bf4
Cr-Commit-Position: refs/heads/master@{#33699}

Powered by Google App Engine
This is Rietveld 408576698