src/isolate.cc - Issue 1653423002: Add the data parameter back to the access check callback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/isolate.cc

Issue 1653423002: Add the data parameter back to the access check callback (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/isolate.cc

diff --git a/src/isolate.cc b/src/isolate.cc

index 40d4c9fc56587c7b534f68f01fb1e3f5c478b576..4f98e87eb8bdd586866feee0e399f530448d7f36 100644

--- a/src/isolate.cc

+++ b/src/isolate.cc

@@ -843,7 +843,7 @@ bool Isolate::MayAccess(Handle<Context> accessing_context,

VMState<EXTERNAL> state(this);

if (callback) {

return callback(v8::Utils::ToLocal(accessing_context),

- v8::Utils::ToLocal(receiver));

+ v8::Utils::ToLocal(receiver), v8::Utils::ToLocal(data));

}

Handle<Object> key = factory()->undefined_value();

return named_callback(v8::Utils::ToLocal(receiver), v8::Utils::ToLocal(key),

« no previous file with comments | « src/api.cc ('k') | test/cctest/test-accessors.cc » ('j') | no next file with comments »