Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 1653313002: Changed the default value for Empty Dir Attribute (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changed the unittests Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp
index bc3c1bd86be98f88dc2d7ee1f7e9544a13ba772f..090d095dc9c05ba2d3c1880d06541ea4e77c95a2 100644
--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp
@@ -232,10 +232,13 @@ void HTMLElement::collectStyleForPresentationAttribute(const QualifiedName& name
if (equalIgnoringCase(value, "auto")) {
addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, unicodeBidiAttributeForDirAuto(this));
} else {
- if (isValidDirAttribute(value))
+ if (isValidDirAttribute(value)) {
addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, value);
- else
- addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");
+ } else {
chakshu 2016/02/11 05:55:37 @kojii Can you look at this fix for default value
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "");
+ if (hasTagName(bodyTag))
kojii 2016/02/11 13:51:16 Probably isHTMLBodyElement() is better? I'm not ce
chakshu 2016/02/12 06:04:10 isHTMLBodyElement() is basically the wrapper funct
+ addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");
+ }
if (!hasTagName(bdiTag) && !hasTagName(bdoTag) && !hasTagName(outputTag))
addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, CSSValueIsolate);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/imported/web-platform-tests/html/dom/elements/global-attributes/dir-empty-attribute-value-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698