Changed the default value for Empty Dir Attribute

third_party/WebKit/Source/core/html/HTMLElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2011 Motorola Mobility. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 214 matching lines @@
         if (equalIgnoringCase(value, "true")) {
             addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitUserDrag, CSSValueElement);
             addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitUserSelect, CSSValueNone);
         } else if (equalIgnoringCase(value, "false")) {
             addPropertyToPresentationAttributeStyle(style, CSSPropertyWebkitUserDrag, CSSValueNone);
         }
     } else if (name == dirAttr) {
         if (equalIgnoringCase(value, "auto")) {
             addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, unicodeBidiAttributeForDirAuto(this));
         } else {
-            if (isValidDirAttribute(value))
+            if (isValidDirAttribute(value)) {
                 addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, value);
-            else
-                addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");
+            } else {

[chakshu, 2016/02/11 05:55:37]

@kojii Can you look at this fix for default value for invalid dir attribute, as
per the discussion we had?

+                addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "");
+                if (hasTagName(bodyTag))

[kojii, 2016/02/11 13:51:16]

Probably isHTMLBodyElement() is better? I'm not certain how practically it
differs though.

Also, minor, but this code adds CSSPropertyDirection twice if body. Better to
add only once.

[chakshu, 2016/02/12 06:04:10]

isHTMLBodyElement() is basically the wrapper function for hasTagName(bodyTag) so
yeah, it is better to use it but practically it does not differ though. Fixed
the changes asked for.

+                    addPropertyToPresentationAttributeStyle(style, CSSPropertyDirection, "ltr");
+            }
             if (!hasTagName(bdiTag) && !hasTagName(bdoTag) && !hasTagName(outputTag))
                 addPropertyToPresentationAttributeStyle(style, CSSPropertyUnicodeBidi, CSSValueIsolate);
         }
     } else if (name.matches(XMLNames::langAttr)) {
         mapLanguageAttributeToLocale(value, style);
     } else if (name == langAttr) {
         // xml:lang has a higher priority than lang.
         if (!fastHasAttribute(XMLNames::langAttr))
             mapLanguageAttributeToLocale(value, style);
     } else {
@@ skipping 787 matching lines @@
 #ifndef NDEBUG
 
 // For use in the debugger
 void dumpInnerHTML(blink::HTMLElement*);
 
 void dumpInnerHTML(blink::HTMLElement* element)
 {
     printf("%s\n", element->innerHTML().ascii().data());
 }
 #endif