Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/shell/BUILD.gn

Issue 1653003006: Move gn _run target generation into test(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/BUILD.gn ('k') | gin/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/shell/BUILD.gn
diff --git a/extensions/shell/BUILD.gn b/extensions/shell/BUILD.gn
index 52e3cabee3f75a4dea804fa549a9a19d02ae203e..a98d7042d28897ab22c1f50d92f1edfd027c0446 100644
--- a/extensions/shell/BUILD.gn
+++ b/extensions/shell/BUILD.gn
@@ -145,15 +145,6 @@ if (!(is_chromeos && !use_ozone)) {
}
}
-# TODO(GYP): Delete this after we've converted everything to GN.
-# The _run targets exist only for compatibility w/ GYP.
-group("app_shell_unittests_run") {
- testonly = true
- deps = [
- ":app_shell_unittests",
- ]
-}
-
test("app_shell_unittests") {
sources = rebase_path(app_shell_gypi_values.app_shell_unittests_sources,
".",
« no previous file with comments | « extensions/BUILD.gn ('k') | gin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698