third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('K') | « third_party/WebKit/Source/platform/graphics/CanvasMetrics.cpp ('k') | third_party/WebKit/Source/platform/heap/Heap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

index e0273d7893c170ffe802573b2571fc08dc55163f..afc2ba9ec554d8c98607f322b31cef202edfcaad 100644

--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

@@ -4,11 +4,11 @@

#include "platform/graphics/RecordingImageBufferSurface.h"

+#include "platform/Histogram.h"

#include "platform/graphics/CanvasMetrics.h"

#include "platform/graphics/ExpensiveCanvasHeuristicParameters.h"

#include "platform/graphics/GraphicsContext.h"

#include "platform/graphics/ImageBuffer.h"

-#include "public/platform/Platform.h"

#include "third_party/skia/include/core/SkCanvas.h"

#include "third_party/skia/include/core/SkPictureRecorder.h"

#include "wtf/PassOwnPtr.h"

@@ -75,7 +75,8 @@ void RecordingImageBufferSurface::fallBackToRasterCanvas(FallbackReason reason)

return;

}

- Platform::current()->histogramEnumeration("Canvas.DisplayListFallbackReason", reason, FallbackReasonCount);

+ DEFINE_THREAD_SAFE_STATIC_LOCAL(EnumerationHistogram, canvasFallbackHistogram, new EnumerationHistogram("Canvas.DisplayListFallbackReason", FallbackReasonCount));

+ canvasFallbackHistogram.count(reason);

m_fallbackSurface = m_fallbackFactory->createSurface(size(), opacityMode());

m_fallbackSurface->setImageBuffer(m_imageBuffer);