third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('K') | « third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp ('k') | third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

index 45f60157489c323f5c539ae6d260f46782330046..b1976633014b46f05795feded46f43c38913269a 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBFactory.cpp

@@ -35,12 +35,12 @@

#include "core/dom/ExceptionCode.h"

#include "modules/indexeddb/IDBDatabase.h"

#include "modules/indexeddb/IDBDatabaseCallbacks.h"

-#include "modules/indexeddb/IDBHistograms.h"

#include "modules/indexeddb/IDBKey.h"

#include "modules/indexeddb/IDBTracing.h"

#include "modules/indexeddb/IndexedDBClient.h"

#include "modules/indexeddb/WebIDBCallbacksImpl.h"

#include "modules/indexeddb/WebIDBDatabaseCallbacksImpl.h"

+#include "platform/Histogram.h"

#include "platform/weborigin/DatabaseIdentifier.h"

#include "platform/weborigin/SecurityOrigin.h"

#include "public/platform/Platform.h"

@@ -103,7 +103,7 @@ IDBOpenDBRequest* IDBFactory::open(ScriptState* scriptState, const String& name,

IDBOpenDBRequest* IDBFactory::openInternal(ScriptState* scriptState, const String& name, int64_t version, ExceptionState& exceptionState)

{

- Platform::current()->histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBOpenCall, IDBMethodsMax);

+ IDBDatabase::recordApiCallsHistogram(IDBOpenCall);

ASSERT(version >= 1 || version == IDBDatabaseMetadata::NoIntVersion);

if (!isContextValid(scriptState->executionContext()))

return nullptr;

@@ -134,7 +134,7 @@ IDBOpenDBRequest* IDBFactory::open(ScriptState* scriptState, const String& name,

IDBOpenDBRequest* IDBFactory::deleteDatabase(ScriptState* scriptState, const String& name, ExceptionState& exceptionState)

{

IDB_TRACE("IDBFactory::deleteDatabase");

- Platform::current()->histogramEnumeration("WebCore.IndexedDB.FrontEndAPICalls", IDBDeleteDatabaseCall, IDBMethodsMax);

+ IDBDatabase::recordApiCallsHistogram(IDBDeleteDatabaseCall);

if (!isContextValid(scriptState->executionContext()))

return nullptr;

if (!scriptState->executionContext()->securityOrigin()->canAccessDatabase()) {