third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLMediaElement.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index f8227ceb08b9f23789a9f777e3d47f94318a4d40..5b76bf6d3707991fe1b5bf843422099fec2b5876 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -42,8 +42,8 @@

#include "core/layout/LayoutSlider.h"

#include "core/layout/LayoutTheme.h"

#include "core/layout/LayoutVideo.h"

+#include "platform/Histogram.h"

#include "platform/RuntimeEnabledFeatures.h"

-#include "public/platform/Platform.h"

namespace blink {

@@ -623,7 +623,8 @@ bool MediaControlCastButtonElement::keepEventInNode(Event* event)

void MediaControlCastButtonElement::recordMetrics(CastOverlayMetrics metric)

{

ASSERT(m_isOverlayButton);

- Platform::current()->histogramEnumeration("Cast.Sender.Overlay", static_cast<int>(metric), static_cast<int>(CastOverlayMetrics::Count));

+ DEFINE_STATIC_LOCAL(EnumerationHistogram, overlayHistogram, ("Cast.Sender.Overlay", static_cast<int>(CastOverlayMetrics::Count)));

+ overlayHistogram.count(static_cast<int>(metric));

}

// ----------------------------