third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/FontFaceSet.cpp ('k') | third_party/WebKit/Source/core/css/RemoteFontFaceSource.cpp » ('j') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp

diff --git a/third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp b/third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp

index 59074cf4fd92cc61df1e6559385ba6db74eb038e..4ea73e26d89176c6217cce40ccad4c992eb71525 100644

--- a/third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp

+++ b/third_party/WebKit/Source/core/css/LocalFontFaceSource.cpp

@@ -4,10 +4,10 @@

#include "core/css/LocalFontFaceSource.h"

+#include "platform/Histogram.h"

#include "platform/fonts/FontCache.h"

#include "platform/fonts/FontDescription.h"

#include "platform/fonts/SimpleFontData.h"

-#include "public/platform/Platform.h"

namespace blink {

@@ -29,7 +29,8 @@ void LocalFontFaceSource::LocalFontHistograms::record(bool loadSuccess)

if (m_reported)

return;

m_reported = true;

- Platform::current()->histogramEnumeration("WebFont.LocalFontUsed", loadSuccess ? 1 : 0, 2);

+ DEFINE_STATIC_LOCAL(EnumerationHistogram, localFontUsedHistogram, ("WebFont.LocalFontUsed", 2));

+ localFontUsedHistogram.count(loadSuccess ? 1 : 0);

}

} // namespace blink