third_party/WebKit/Source/core/css/FontFace.cpp - Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/FontFace.cpp

Issue 1652983005: Remove Enumeration Histograms from the Blink Platform API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master_blink_histograms_5a

Patch Set: Rebase two new histograms were added today Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp ('k') | third_party/WebKit/Source/core/css/FontFaceSet.cpp » ('j') | third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/FontFace.cpp

diff --git a/third_party/WebKit/Source/core/css/FontFace.cpp b/third_party/WebKit/Source/core/css/FontFace.cpp

index 2f4661d9dc67192a1e0ebcf29cf0d26a4db07a13..c1e0181c16c89850f6cba11a0853dd96c2bce827 100644

--- a/third_party/WebKit/Source/core/css/FontFace.cpp

+++ b/third_party/WebKit/Source/core/css/FontFace.cpp

@@ -58,8 +58,8 @@

#include "core/frame/Settings.h"

#include "core/frame/UseCounter.h"

#include "platform/FontFamilyNames.h"

+#include "platform/Histogram.h"

#include "platform/SharedBuffer.h"

-#include "public/platform/Platform.h"

namespace blink {

@@ -602,8 +602,10 @@ void FontFace::initCSSFontFace(Document* document, PassRefPtrWillBeRawPtr<CSSVal

m_cssFontFace->addSource(source.release());

}

- if (m_display)

- Platform::current()->histogramEnumeration("WebFont.FontDisplayValue", CSSValueToFontDisplay(m_display.get()), FontDisplayEnumMax);

+ if (m_display) {

+ DEFINE_STATIC_LOCAL(EnumerationHistogram, fontDisplayHistogram, ("WebFont.FontDisplayValue", FontDisplayEnumMax));

+ fontDisplayHistogram.count(CSSValueToFontDisplay(m_display.get()));

+ }

}

void FontFace::initCSSFontFace(const unsigned char* data, size_t size)