Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1652963003: Issue 25623. When adding the 'async' modifier, change the return type. (Closed)

Created:
4 years, 10 months ago by scheglov
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -13 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 4 chunks +37 lines, -11 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 3 chunks +94 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 10 months ago (2016-02-01 16:59:57 UTC) #1
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-01 17:28:31 UTC) #2
scheglov
4 years, 10 months ago (2016-02-01 18:35:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86106d7a6d1ea479b6ec139d7c54e84f6630eede (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698