Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: pkg/analysis_server/test/services/correction/fix_test.dart

Issue 1652963003: Issue 25623. When adding the 'async' modifier, change the return type. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix_internal.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/correction/fix_test.dart
diff --git a/pkg/analysis_server/test/services/correction/fix_test.dart b/pkg/analysis_server/test/services/correction/fix_test.dart
index 24d3f1894809ebb2fe432d724c5096cbb4e953c3..2b0db037973cc6440375abb6549662764b44d788 100644
--- a/pkg/analysis_server/test/services/correction/fix_test.dart
+++ b/pkg/analysis_server/test/services/correction/fix_test.dart
@@ -352,7 +352,7 @@ class A {}
test_addSync_asyncFor() async {
resolveTestUnit('''
import 'dart:async';
-main(Stream<String> names) {
+void main(Stream<String> names) {
await for (String name in names) {
print(name);
}
@@ -362,7 +362,7 @@ main(Stream<String> names) {
DartFixKind.ADD_ASYNC,
'''
import 'dart:async';
-main(Stream<String> names) async {
+Future main(Stream<String> names) async {
await for (String name in names) {
print(name);
}
@@ -433,6 +433,98 @@ main() async => await foo();
''');
}
+ test_addSync_returnFuture() async {
+ errorFilter = (AnalysisError error) {
+ return error.errorCode == StaticWarningCode.UNDEFINED_IDENTIFIER;
+ };
+ resolveTestUnit('''
+foo() {}
+int main() {
+ await foo();
+ return 42;
+}
+''');
+ await assertHasFix(
+ DartFixKind.ADD_ASYNC,
+ '''
+import 'dart:async';
+
+foo() {}
+Future<int> main() async {
+ await foo();
+ return 42;
+}
+''');
+ }
+
+ test_addSync_returnFuture_alreadyFuture() async {
+ errorFilter = (AnalysisError error) {
+ return error.errorCode == StaticWarningCode.UNDEFINED_IDENTIFIER;
+ };
+ resolveTestUnit('''
+import 'dart:async';
+foo() {}
+Future<int> main() {
+ await foo();
+ return 42;
+}
+''');
+ await assertHasFix(
+ DartFixKind.ADD_ASYNC,
+ '''
+import 'dart:async';
+foo() {}
+Future<int> main() async {
+ await foo();
+ return 42;
+}
+''');
+ }
+
+ test_addSync_returnFuture_dynamic() async {
+ errorFilter = (AnalysisError error) {
+ return error.errorCode == StaticWarningCode.UNDEFINED_IDENTIFIER;
+ };
+ resolveTestUnit('''
+foo() {}
+dynamic main() {
+ await foo();
+ return 42;
+}
+''');
+ await assertHasFix(
+ DartFixKind.ADD_ASYNC,
+ '''
+foo() {}
+dynamic main() async {
+ await foo();
+ return 42;
+}
+''');
+ }
+
+ test_addSync_returnFuture_noType() async {
+ errorFilter = (AnalysisError error) {
+ return error.errorCode == StaticWarningCode.UNDEFINED_IDENTIFIER;
+ };
+ resolveTestUnit('''
+foo() {}
+main() {
+ await foo();
+ return 42;
+}
+''');
+ await assertHasFix(
+ DartFixKind.ADD_ASYNC,
+ '''
+foo() {}
+main() async {
+ await foo();
+ return 42;
+}
+''');
+ }
+
test_boolean() async {
resolveTestUnit('''
main() {
« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix_internal.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698