Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1652883002: Fix a crashier in CPDFSDK_Document::GetPageView() (Closed)

Created:
4 years, 10 months ago by jun_fang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, Jim Wang, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Fix a crashier in CPDFSDK_Document::GetPageView() XFA document should be released before SDK document is released. BUG=pdfium:369 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/1be28d1b037de32c75632e10e7d2fc758fe7f962

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp View 2 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
jun_fang
https://codereview.chromium.org/1652883002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp File fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp (left): https://codereview.chromium.org/1652883002/diff/1/fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp#oldcode490 fpdfsdk/src/fpdfxfa/fpdfxfa_doc.cpp:490: m_pSDKDoc->GetPageView(pPage)->ClearFXAnnots(); When a XFA page is deleted, it doesn't ...
4 years, 10 months ago (2016-02-01 09:54:29 UTC) #3
Tom Sepez
lgtm
4 years, 10 months ago (2016-02-01 20:02:54 UTC) #4
jun_fang
4 years, 10 months ago (2016-02-02 04:19:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1be28d1b037de32c75632e10e7d2fc758fe7f962 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698