Android: Use virtualized context only for those with compatible config

ui/gl/gl_surface_egl.cc

Index: ui/gl/gl_surface_egl.cc
diff --git a/ui/gl/gl_surface_egl.cc b/ui/gl/gl_surface_egl.cc
index 081ffa546ee58e12e5a4c559e22b1043c24b4691..fcaed37659eefdd7ca7e363cd4b15a5a14f3126f 100644
--- a/ui/gl/gl_surface_egl.cc
+++ b/ui/gl/gl_surface_egl.cc
@@ -16,6 +16,7 @@
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/sys_info.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
 #include "ui/gfx/geometry/rect.h"
@@ -436,8 +437,7 @@ void GetEGLInitDisplays(bool supports_angle_d3d,
 }
 
 GLSurfaceEGL::GLSurfaceEGL() :
-    config_(nullptr),
-    format_(SURFACE_DEFAULT) {}
+    config_(nullptr) {}
 
 bool GLSurfaceEGL::InitializeOneOff() {
   static bool initialized = false;
@@ -619,10 +619,6 @@ NativeViewGLSurfaceEGL::NativeViewGLSurfaceEGL(EGLNativeWindowType window)
 #endif
 }
 
-bool NativeViewGLSurfaceEGL::Initialize() {
-  return Initialize(SURFACE_DEFAULT);
-}
-
 bool NativeViewGLSurfaceEGL::Initialize(GLSurface::Format format) {
   format_ = format;
   return Initialize(nullptr);
@@ -935,6 +931,15 @@ PbufferGLSurfaceEGL::PbufferGLSurfaceEGL(const gfx::Size& size)
     size_.SetSize(1, 1);
 }
 
+bool PbufferGLSurfaceEGL::Initialize() {
+  GLSurface::Format format = SURFACE_DEFAULT;
+#if defined(OS_ANDROID)

[no sievers, 2016/02/22 22:50:03]

nit: Can you put a comment that we do this for allowing context virtualization
which requires on- and offscreen to use a compatible config. We expect the
client to request RGB565 onscreen surfaces also for this to work (with the
exception of fullscreen video).

[Jinsuk Kim, 2016/02/23 01:27:38]

Done.

+  if (base::SysInfo::IsLowEndDevice())
+    format = SURFACE_RGB565;
+#endif
+  return Initialize(format);
+}
+
 bool PbufferGLSurfaceEGL::Initialize(GLSurface::Format format) {
   EGLSurface old_surface = surface_;
   format_ = format;