Android: Use virtualized context only for those with compatible config

ui/gl/gl_surface_egl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gl/gl_surface_egl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <map>
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/strings/string_number_conversions.h"
+#include "base/sys_info.h"
 #include "base/trace_event/trace_event.h"
 #include "build/build_config.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gl/egl_util.h"
 #include "ui/gl/gl_context.h"
 #include "ui/gl/gl_image.h"
 #include "ui/gl/gl_implementation.h"
 #include "ui/gl/gl_surface_stub.h"
 #include "ui/gl/gl_switches.h"
 #include "ui/gl/scoped_make_current.h"
@@ skipping 400 matching lines @@
   }
 
   // If no displays are available due to missing angle extensions or invalid
   // flags, request the default display.
   if (init_displays->empty()) {
     init_displays->push_back(DEFAULT);
   }
 }
 
 GLSurfaceEGL::GLSurfaceEGL() :
-    config_(nullptr),
-    format_(SURFACE_DEFAULT) {}
+    config_(nullptr) {}
 
 bool GLSurfaceEGL::InitializeOneOff() {
   static bool initialized = false;
   if (initialized)
     return true;
 
   InitializeDisplay();
   if (g_display == EGL_NO_DISPLAY)
     return false;
 
@@ skipping 161 matching lines @@
 
 #if defined(OS_WIN)
   vsync_override_ = false;
   swap_generation_ = 0;
   RECT windowRect;
   if (GetClientRect(window_, &windowRect))
     size_ = gfx::Rect(windowRect).size();
 #endif
 }
 
-bool NativeViewGLSurfaceEGL::Initialize() {
-  return Initialize(SURFACE_DEFAULT);
-}
-
 bool NativeViewGLSurfaceEGL::Initialize(GLSurface::Format format) {
   format_ = format;
   return Initialize(nullptr);
 }
 
 bool NativeViewGLSurfaceEGL::Initialize(
     scoped_ptr<VSyncProvider> sync_provider) {
   DCHECK(!surface_);
 
   if (!GetDisplay()) {
@@ skipping 292 matching lines @@
 
 PbufferGLSurfaceEGL::PbufferGLSurfaceEGL(const gfx::Size& size)
     : size_(size),
       surface_(NULL) {
   // Some implementations of Pbuffer do not support having a 0 size. For such
   // cases use a (1, 1) surface.
   if (size_.GetArea() == 0)
     size_.SetSize(1, 1);
 }
 
+bool PbufferGLSurfaceEGL::Initialize() {
+  GLSurface::Format format = SURFACE_DEFAULT;
+#if defined(OS_ANDROID)

[no sievers, 2016/02/22 22:50:03]

nit: Can you put a comment that we do this for allowing context virtualization
which requires on- and offscreen to use a compatible config. We expect the
client to request RGB565 onscreen surfaces also for this to work (with the
exception of fullscreen video).

[Jinsuk Kim, 2016/02/23 01:27:38]

Done.

+  if (base::SysInfo::IsLowEndDevice())
+    format = SURFACE_RGB565;
+#endif
+  return Initialize(format);
+}
+
 bool PbufferGLSurfaceEGL::Initialize(GLSurface::Format format) {
   EGLSurface old_surface = surface_;
   format_ = format;
 
   EGLDisplay display = GetDisplay();
   if (!display) {
     LOG(ERROR) << "Trying to create surface with invalid display.";
     return false;
   }
 
@@ skipping 150 matching lines @@
 }
 
 void* SurfacelessEGL::GetShareHandle() {
   return NULL;
 }
 
 SurfacelessEGL::~SurfacelessEGL() {
 }
 
 }  // namespace gfx