Android: Use virtualized context only for those with compatible config

ui/gl/gl_surface_osmesa.cc

Index: ui/gl/gl_surface_osmesa.cc
diff --git a/ui/gl/gl_surface_osmesa.cc b/ui/gl/gl_surface_osmesa.cc
index 7825942f7707dfe1a404c089a72e7222a2aaab4f..f65cdee15e6ec9ce422c5065445ff67b4637d83a 100644
--- a/ui/gl/gl_surface_osmesa.cc
+++ b/ui/gl/gl_surface_osmesa.cc
@@ -20,10 +20,10 @@ GLSurfaceOSMesa::GLSurfaceOSMesa(OSMesaSurfaceFormat format,
     : size_(size) {
   switch (format) {
     case OSMesaSurfaceFormatBGRA:
-      format_ = OSMESA_BGRA;
+      format_ = static_cast<GLSurface::Format>(OSMESA_BGRA);

[no sievers, 2016/02/19 20:25:18]

hmm this seems like a hack. how about just adding OSMESA_BGRA and _RGBA to the
GLSurface enum?

And then in GLContextOSMesa where this is used you can just have a little switch
statement that converts it to a mesa GLenum. (This is actually a bit hacky in
mesa itself since it mixes actual GL formats with arbitrary mesa defines.)

[Jinsuk Kim, 2016/02/20 13:56:57]

Had meant to do it but didn't. This is certainly better. Done.

       break;
     case OSMesaSurfaceFormatRGBA:
-      format_ = OSMESA_RGBA;
+      format_ = static_cast<GLSurface::Format>(OSMESA_RGBA);
       break;
   }
   // Implementations of OSMesa surface do not support having a 0 size. In such
@@ -102,10 +102,6 @@ void* GLSurfaceOSMesa::GetHandle() {
   return buffer_.get();
 }
 
-unsigned GLSurfaceOSMesa::GetFormat() {
-  return format_;
-}
-
 GLSurfaceOSMesa::~GLSurfaceOSMesa() {
   Destroy();
 }